New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Header.Select fromSafe, toRaw multiple, and Aux #4787
Adding Header.Select fromSafe, toRaw multiple, and Aux #4787
Conversation
We should probably target 0.22 with this: that's where the new header model debuts. It shouldn't be hard to merge to main, since it's pure work. |
29fcb28
to
6d0e735
Compare
Done. |
Haven't forgotten this. 0.21 sucked up all my time, but this is absolutely necessary before 0.22 so we don't leave rho hanging. Extra opinions welcome. |
So this is still in draft. We want to release 0.22.0, but are blocked by a couple issues and circe. I also want to unblock Rho. We could merge this as is and clean it up before the final release, or we could let rho work off snapshots/source dependencies and clean up before the final release. Thoughts? |
I think I can make some time this weekend for the suggestions here, and hopefully any associated testing. |
That sounds great. I have a stupid busy weekend, so if we can get things greened up, I may do a milestone today. But I will commit to do another release as soon as this is ready, because we don't want to leave Rho hanging. |
Some enhancements needed to help enable Rho support.
6d0e735
to
0fe3fa6
Compare
Just 2 questions that need answering on the above issues, and I'd be ready to move this out of Draft. |
Make `toRaw` return a `NonEmptyList`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is sufficient, and we can do an RC with it when circe-0.14 is ready and make sure Rho has a path forward.
Looks like we also broke this:
|
I can take a look. |
Some enhancements needed to help enable Rho support.
See: http4s/rho#501 for some usage example.
I could use feedback on these, once I get buy in I'll happily add/fixup the unit tests!
Resolves #4706