Bugfix/4822 #4823
Merged
Bugfix/4822 #4823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamnis
approved these changes
May 13, 2021
rossabaker
reviewed
May 15, 2021
| def hasConnection(expected: String): Boolean = | ||
| headers.exists { | ||
| case Header.Raw(name, value) => | ||
| name == connectionCi && value.toLowerCase.contains(expected) |
There was a problem hiding this comment.
Should always use a Locale on toLowerCase. Most people use Locale.US, but I use Locale.ROOT.
There was a problem hiding this comment.
This will generate false positives if keep-alive or close are substrings of a different token, but I suppose those people are just asking for trouble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4822 . The issue is that AB operates on HTTP/1.0 and the absence of a connection header on HTTP/1.0 implies that the client wishes the connection to be terminated after the response is written