Merged
Conversation
rossabaker
approved these changes
May 16, 2021
Member
rossabaker
left a comment
rossabaker
left a comment
There was a problem hiding this comment.
Thanks! I think we should backport this to 0.22, as the new header model originates there.
| def clearCookie: headers.`Set-Cookie` = | ||
| headers.`Set-Cookie`(copy(content = "", expires = Some(HttpDate.Epoch))) | ||
| def clearCookie: ResponseCookie = | ||
| copy(content = "", expires = Some(HttpDate.Epoch)) |
Member
There was a problem hiding this comment.
Using copy leaves other attributes. Is this desirable? I think yes?
Member
|
Argh, I meant to cherry-pick this! |
rossabaker
pushed a commit
that referenced
this pull request
May 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
putHeadersdeduplicates, callingremoveCookierepeatedly will remove the first one.