Lazy header parse #4933
Merged
Lazy header parse #4933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaasAhsan
commented
Jun 20, 2021
| @@ -182,7 +182,7 @@ object Header { | |||
| type Aux[A, G[_]] = Select[A] { type F[B] = G[B] } | |||
|
|
|||
| def fromRaw[A](h: Header.Raw)(implicit ev: Header[A, _]): Option[Ior[ParseFailure, A]] = | |||
| (h.name == Header[A].name).guard[Option].as(Header[A].parse(h.value).toIor) | |||
| (h.name == Header[A].name).guard[Option].map(_ => Header[A].parse(h.value).toIor) | |||
There was a problem hiding this comment.
this was the quickest change, but i wouldn't be against rewriting this to be an if statement so the laziness is more apparent. or we can add a comment
rossabaker
approved these changes
Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this when while trying to debug why a header parser was throwing an exception on a header it wasn't even intended for. The way it's coded right now, if we try to parse a header from its raw form, it'll parse every preceding header searched as well, even if the name doesn't match. This is definitely a performance hit when headers are queried