Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
IdleTimeoutStage
's was observed. Now there is zero or oneIdleTimeoutStage
perHttp1Connection
. That stage is created together with the connection and keeps being reused though the life of the connection. The logic ofIdleTimeoutStage
makes sure that at most one timeout is scheduled.IdleTimoutStage
per request. In many cases that cost is minuscule. But that's not the case when using log4j2 on Java 11 (see similar issue in armeria Performance degradation when using JDK 11 and log4j2 line/armeria#2306).ReadBufferStage
which was supposed to address the same issue as Read from an idle blaze-client connection to detect when server closes it #4810, but apparently it didn't work. And since Read from an idle blaze-client connection to detect when server closes it #4810 is merged theReadBufferStage
it obsolete.