Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boopickle 1.4.0 #4991

Merged
merged 3 commits into from Jul 30, 2021
Merged

Boopickle 1.4.0 #4991

merged 3 commits into from Jul 30, 2021

Conversation

rossabaker
Copy link
Member

No description provided.

@rossabaker
Copy link
Member Author

@cquiroz Do you know why this doesn't compile in Scala 3? I see upstream they split off the tests between Scala 2 and Scala 3, but I don't spot the difference in the relevant part.

@cquiroz
Copy link
Member

cquiroz commented Jul 29, 2021

/cc I'm a bit out of the loop, maybe @japgolly

@japgolly
Copy link

Hello! The problem is in build.sbt:401:

Http4sPlugin.boopickle.cross(CrossVersion.for3Use2_13)

should be

Http4sPlugin.boopickle

I tried it locally and with that change all tests compile and pass :)

@rossabaker
Copy link
Member Author

Oh, right! I generally avoid that cross-compilation feature, but we used it to keep publishing the integration for Scala 2 until boopickle supported Scala 3. Thank you, @japgolly!

@japgolly
Copy link

No worries, happy to help! ☺️

@rossabaker rossabaker marked this pull request as ready for review July 30, 2021 03:03
@rossabaker
Copy link
Member Author

There's a slight binary incompatibility in this version of boopickle. Our usual conservative approach would be to defer this upgrade to http4s-0.23, but these probably aren't going to hurt anyone?

sbt:boopickle> boopickleJVM/mimaReportBinaryIssues
[error] boopickle: Failed binary compatibility check against io.suzaku:boopickle_2.13:1.3.3! Found 2 potential problems
[error]  * method bp()boopickle.BasicPicklers#BytePickler# in object boopickle.BasicPicklers#BigDecimalPickler has a different result type in current version, where it is boopickle.Pickler rather than boopickle.BasicPicklers#BytePickler#
[error]    filter with: ProblemFilters.exclude[IncompatibleResultTypeProblem]("boopickle.BasicPicklers#BigDecimalPickler.bp")
[error]  * method bp()boopickle.BasicPicklers#BytePickler# in object boopickle.BasicPicklers#BigIntPickler has a different result type in current version, where it is boopickle.Pickler rather than boopickle.BasicPicklers#BytePickler#
[error]    filter with: ProblemFilters.exclude[IncompatibleResultTypeProblem]("boopickle.BasicPicklers#BigIntPickler.bp")
[error] stack trace is suppressed; run last mimaReportBinaryIssues for the full output

@japgolly
Copy link

@rossabaker Oh sorry about that, mima isn't enabled in the Boopickle build. Those are completely reasonable differences to ignore. Now that I see these methods, they shouldn't even be public anyway, and there's no reason for anyone would have used them. I'd say ignore away

@rossabaker rossabaker merged commit e263ea6 into series/0.22 Jul 30, 2021
@rossabaker rossabaker deleted the boopickle-1.4.0 branch July 30, 2021 16:38
rossabaker added a commit that referenced this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants