Deprecate DefaultCharset, use UTF-8 directly
#5512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamnis
approved these changes
Oct 29, 2021
danicheg
approved these changes
Oct 29, 2021
| @@ -34,6 +34,7 @@ package object http4s { | |||
|
|
|||
| type ParseResult[+A] = Either[ParseFailure, A] | |||
|
|
|||
| @deprecated("Use Charset.`UTF-8` directly", "0.22.8") | |||
There was a problem hiding this comment.
nitpick (non-blocking at all):
perhaps, in the 0.23 series a 'since' version should be different. It may be a bit odd — deprecated in 0.22.8 and not in 0.23.0 :)
There was a problem hiding this comment.
Yes, I think when Ross merges 0.22 -> 0.23 -> 1.0 he fixes these :)
rossabaker
pushed a commit
to http4s/http4s-scala-xml-1
that referenced
this pull request
Apr 19, 2022
armanbilge
pushed a commit
to http4s/http4s-scalatags
that referenced
this pull request
May 2, 2022
armanbilge
pushed a commit
to http4s/http4s-twirl
that referenced
this pull request
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DefaultCharsetalias served a purpose when it was introduced 6 years ago, but in 2021 anybody who has to think about charsets knows that UTF-8 is the universal default. By inlining it we remove the cognitive burden of needing to know thatDefaultCharsetis a global alias for UTF-8.