Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send multiple chunks when testing chunked requests #5552

merged 1 commit into from Nov 10, 2021


Copy link

In it's current shape the "POST a chunked body" test sends a request with just one chunk (which may be transferred together with the head of the request). That means that the test provides poor coverage of the implementation of chunked encoding. In order to improve the coverage I changed the request body to contain multiple chunks (implemented similarly to the /chunked in the GetRoutes).

Copy link

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find.

@rossabaker rossabaker merged commit 60cac1b into http4s:series/0.22 Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants