Update sbt-scalajs, scalajs-compiler, ... to 1.10.0 in series/0.23 #6245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scala-steward
force-pushed
the
update/series/0.23/sbt-scalajs-1.10.0
branch
from
302f49a
to
6d96ad9
Compare
mergify
bot
added
series/0.23
|
If the build passes, absolutely merge. It's forward-compatible with 1.8.0 and 1.9.0 and furthermore fixes CVE-2022-28355 aka GHSA-j2f9-w8wh-9ww4. Otherwise, I think we should get this fixed via CE, see: Edit: seems the build is broken. So let's wait for CE 3.3.11. |
|
@Mergifyio update |
✅ Branch has been successfully updated |
armanbilge
reviewed
Apr 6, 2022
Comment on lines
+50
to
+60
| @deprecated("Preserved for bincompat", "0.23.12") | ||
| def apply[G[_], F[_]](headerName: CIString, http: Http[G, F], G: Sync[G]): Http[G, F] = | ||
| apply(headerName)(http)(G, UUIDGen.fromSync(G)) | ||
|
|
||
| def apply[G[_], F[_]]( | ||
| headerName: CIString | ||
| )(http: Http[G, F])(implicit G: Sync[G]): Http[G, F] = | ||
| )(http: Http[G, F])(implicit G: Sync[G], gen: UUIDGen[G]): Http[G, F] = | ||
| Kleisli[G, Request[F], Response[F]] { req => | ||
| for { | ||
| header <- req.headers.get(headerName).map(_.head) match { | ||
| case None => G.delay(Header.Raw(headerName, UUID.randomUUID().toString())) | ||
| case None => UUIDGen.randomString[G].map(Header.Raw(headerName, _)) |
There was a problem hiding this comment.
What's good for JS is good for JVM too.
armanbilge
approved these changes
Apr 6, 2022
danicheg
reviewed
Apr 7, 2022
| def apply[G[_], F[_]]( | ||
| headerName: CIString | ||
| )(http: Http[G, F])(implicit G: Sync[G]): Http[G, F] = | ||
| )(http: Http[G, F])(implicit G: Sync[G], gen: UUIDGen[G]): Http[G, F] = |
There was a problem hiding this comment.
UUIDGen is a typeclass? 🤯 Java enters the typeclass-room 😎
|
I think this is quite good, so let's go onward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
from 1.9.0 to 1.10.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
Files still referring to the old version number
The following files still refer to the old version number (1.9.0).
You might want to review and update them manually.
Ignore future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:labels: library-update, early-semver-minor, semver-spec-minor, old-version-remains, commit-count:1