Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to customize flags for file decoders #6982

Merged

Conversation

armanbilge
Copy link
Member

@armanbilge armanbilge commented Feb 19, 2023

E.g. to append to an existing file.

@mergify mergify bot added series/0.23 PRs targeting 0.23.x module:core labels Feb 19, 2023
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some day I'll make up my mind how I feel about overloads, but I like the functionality and I don't have a better name for the new ones.

@armanbilge
Copy link
Member Author

Yeah, I went through the same thought process on this one. At least it's not default args 🙃

Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like pure overloads but hate them powered with default arguments. There are none of them here, so that is greenlit from me 👍🏻

@armanbilge armanbilge merged commit d93de65 into http4s:series/0.23 Feb 19, 2023
@rossabaker
Copy link
Member

My only hesitation with this style of overload in general is that they are a nuisance for partial application. This breaks source compatibility. But I doubt very many people are using it that way here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:core series/0.23 PRs targeting 0.23.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants