Fix minor issue with Authorization header parser #87

Merged
merged 1 commit into from Nov 26, 2014

Conversation

Projects
None yet
3 participants
@gribbet
Contributor

gribbet commented Nov 26, 2014

No description provided.

@rossabaker

This comment has been minimized.

Show comment
Hide comment
@rossabaker

rossabaker Nov 26, 2014

Member

I'm travelling and haven't reviewed this, but it looks like a candidate for
an 0.4.2 release.
On Nov 26, 2014 12:06 PM, "gribbet" notifications@github.com wrote:


You can merge this Pull Request by running

git pull https://github.com/gribbet/http4s master

Or view, comment on, or merge it at:

#87
Commit Summary

  • Fix minor issue with Authorization header parser

File Changes

Patch Links:

Reply to this email directly or view it on GitHub
#87.

Member

rossabaker commented Nov 26, 2014

I'm travelling and haven't reviewed this, but it looks like a candidate for
an 0.4.2 release.
On Nov 26, 2014 12:06 PM, "gribbet" notifications@github.com wrote:


You can merge this Pull Request by running

git pull https://github.com/gribbet/http4s master

Or view, comment on, or merge it at:

#87
Commit Summary

  • Fix minor issue with Authorization header parser

File Changes

Patch Links:

Reply to this email directly or view it on GitHub
#87.

@bryce-anderson

This comment has been minimized.

Show comment
Hide comment
@bryce-anderson

bryce-anderson Nov 26, 2014

Member

Its a simple fix. I'll check to make sure its right (I'm 99% sure it is) and then merge it.

Member

bryce-anderson commented Nov 26, 2014

Its a simple fix. I'll check to make sure its right (I'm 99% sure it is) and then merge it.

bryce-anderson added a commit that referenced this pull request Nov 26, 2014

Merge pull request #87 from gribbet/master
Fix minor issue with Authorization header parser

@bryce-anderson bryce-anderson merged commit 4808169 into http4s:master Nov 26, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@bryce-anderson

This comment has been minimized.

Show comment
Hide comment
@bryce-anderson

bryce-anderson Nov 26, 2014

Member

Thanks @gribbet, this looks good to me. We will likely do a bug fix release on this after we add some tests.

Member

bryce-anderson commented Nov 26, 2014

Thanks @gribbet, this looks good to me. We will likely do a bug fix release on this after we add some tests.

@rossabaker

This comment has been minimized.

Show comment
Hide comment
@rossabaker

rossabaker Dec 1, 2014

Member

Are we still planning an 0.4.2 with this?

Member

rossabaker commented Dec 1, 2014

Are we still planning an 0.4.2 with this?

@bryce-anderson

This comment has been minimized.

Show comment
Hide comment
@bryce-anderson

bryce-anderson Dec 1, 2014

Member

If you want to, let it fly. I couldn't remember your exact git procedure
for bug fix releases so I didn't do it myself while you were gone.

On Mon, Dec 1, 2014 at 3:55 PM, Ross A. Baker notifications@github.com
wrote:

Are we still planning an 0.4.2 with this?


Reply to this email directly or view it on GitHub
#87 (comment).

Member

bryce-anderson commented Dec 1, 2014

If you want to, let it fly. I couldn't remember your exact git procedure
for bug fix releases so I didn't do it myself while you were gone.

On Mon, Dec 1, 2014 at 3:55 PM, Ross A. Baker notifications@github.com
wrote:

Are we still planning an 0.4.2 with this?


Reply to this email directly or view it on GitHub
#87 (comment).

rossabaker pushed a commit that referenced this pull request Mar 24, 2016

Merge pull request #87 from http4s/issue/86
Fix Prepend type param ordering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment