Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve download time #1236

Merged
merged 1 commit into from Dec 17, 2021
Merged

Improve download time #1236

merged 1 commit into from Dec 17, 2021

Conversation

isidentical
Copy link
Contributor

Based on #1232.

@github-actions github-actions bot removed the benchmark label Dec 8, 2021
@isidentical isidentical force-pushed the improve-download-time branch 2 times, most recently from e873c39 to 8b630b9 Compare December 9, 2021 10:54
@httpie httpie deleted a comment from github-actions bot Dec 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

Benchmarks

Benchmark master this_branch
http --download :/big_file.txt (3GB) (download) 5.87 sec 1.82 sec: 3.23x faster
Geometric mean (ref) 1.33x faster

Some benchmarks were hidden from this list because their timings did not change in a significant way (change was within the error margin ±6%).


Benchmark master-complex this_branch-complex
http --download :/big_file.txt (3GB) (download) 5.94 sec 1.85 sec: 3.22x faster
Geometric mean (ref) 1.27x faster

Some benchmarks were hidden from this list because their timings did not change in a significant way (change was within the error margin ±6%).


@github-actions github-actions bot removed the benchmark label Dec 9, 2021
@httpie httpie deleted a comment from codecov-commenter Dec 15, 2021
@isidentical isidentical marked this pull request as ready for review December 15, 2021 08:55
@jkbrzt jkbrzt merged commit c237e15 into master Dec 17, 2021
@jkbrzt jkbrzt deleted the improve-download-time branch December 17, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants