Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship new test suite in source dist #168

Merged
merged 1 commit into from May 19, 2020
Merged

Conversation

@slyon
Copy link
Contributor

@slyon slyon commented May 19, 2020

This makes the test suite available to Debian/Ubuntu/...
It enables distributions to validate the quality of the shipped package.

This new test suite should be used, instead of the deprecated python3/httplib2test.py (see: #166)

@codecov
Copy link

@codecov codecov bot commented May 19, 2020

Codecov Report

Merging #168 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   75.68%   75.68%           
=======================================
  Files           8        8           
  Lines        2616     2616           
=======================================
  Hits         1980     1980           
  Misses        636      636           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f568487...fe3136a. Read the comment docs.

@temoto
Copy link
Member

@temoto temoto commented May 19, 2020

Please ignore makefile, it is not used. Try setup.py sdist or change it or MANIFEST accordingly.

@slyon
Copy link
Contributor Author

@slyon slyon commented May 19, 2020

Thanks for the feedback! I reverted the prior commit and adopted MANIFEST.in accordingly. The tarball created by setup.py sdist now contains the complete new test suite.

This makes the test suite available to Debian/Ubuntu/...
It enables distributions to validate the quality of the shipped package.
@slyon slyon force-pushed the slyon:ship-tests-sdist branch from 8d6c648 to fe3136a May 19, 2020
@temoto temoto merged commit fe3136a into httplib2:master May 19, 2020
3 checks passed
3 checks passed
@codecov
codecov/patch Coverage not affected when comparing f568487...fe3136a
Details
@codecov
codecov/project 75.68% (+0.00%) compared to f568487
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@temoto
Copy link
Member

@temoto temoto commented May 19, 2020

Thank you.

@slyon
Copy link
Contributor Author

@slyon slyon commented May 19, 2020

Thank you, too!
Would you mind spinning a patch release (0.17.4), including this change? So we can get the Debian/Ubuntu auto-testing CI into a green state?

It is currently blocked by the missing test suite:
https://salsa.debian.org/python-team/modules/python-httplib2/-/merge_requests/1

@slyon slyon deleted the slyon:ship-tests-sdist branch May 19, 2020
@slyon slyon restored the slyon:ship-tests-sdist branch May 19, 2020
@temoto
Copy link
Member

@temoto temoto commented May 19, 2020

@slyon 0.17.4 done

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 20, 2020
0.18.0
IMPORTANT security vulnerability CWE-93 CRLF injection
Force %xx quote of space, CR, LF characters in uri.
Special thanks to Recar https://github.com/Ciyfly for discrete notification.
https://cwe.mitre.org/data/definitions/93.html

0.17.4
Ship test suite in source dist
httplib2/httplib2#168
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 27, 2020
www/py-httplib2: security fix

Revisions pulled up:
- www/py-httplib2/Makefile                                      1.24-1.25
- www/py-httplib2/distinfo                                      1.21-1.22

---
   Module Name:    pkgsrc
   Committed By:   adam
   Date:           Wed May 20 15:29:53 UTC 2020

   Modified Files:
           pkgsrc/www/py-httplib2: Makefile distinfo

   Log Message:
   py-httplib2: updated to 0.18.0

   0.18.0
   IMPORTANT security vulnerability CWE-93 CRLF injection
   Force %xx quote of space, CR, LF characters in uri.
   Special thanks to Recar https://github.com/Ciyfly for discrete notification.
   https://cwe.mitre.org/data/definitions/93.html

   0.17.4
   Ship test suite in source dist
   httplib2/httplib2#168

---
   Module Name:    pkgsrc
   Committed By:   adam
   Date:           Thu May 21 06:19:59 UTC 2020

   Modified Files:
           pkgsrc/www/py-httplib2: Makefile distinfo

   Log Message:
   py-httplib2: updated to 0.18.1

   0.18.1
   explicit build-backend workaround for pip build isolation bug
   "AttributeError: 'module' object has no attribute '__legacy__'" on pip install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants