Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSSE token needs to be string not bytes #179

Closed
wants to merge 1 commit into from
Closed

WSSE token needs to be string not bytes #179

wants to merge 1 commit into from

Conversation

@pearmaster
Copy link
Contributor

@pearmaster pearmaster commented Sep 29, 2020

When _wsse_username_token returned bytes, the header would look like

UsernameToken Username="username", PasswordDigest="b'Ue8bnW/FAKEWubcqChWs='", Nonce="673552abeefb06a6", Created="2020-09-29T14:42:57Z"

And the extra b' at the beginning of the password digest would cause authentication to fail.

When `_wsse_username_token` returned bytes, the header would look like
```
UsernameToken Username="username", PasswordDigest="b'Ue8bnW/FAKEWubcqChWs='", Nonce="673552abeefb06a6", Created="2020-09-29T14:42:57Z"
```
And the extra `b'` at the beginning of the password digest would cause authentication to fail.
temoto added a commit that referenced this issue Sep 29, 2020
When `_wsse_username_token` returned bytes, the header would look like
```
UsernameToken Username="username", PasswordDigest="b'Ue8bnW/FAKEWubcqChWs='", Nonce="673552abeefb06a6", Created="2020-09-29T14:42:57Z"
```
And the extra `b'` at the beginning of the password digest would cause authentication to fail.

#179

Co-Authored-By: Sergey Shepelev <temotor@gmail.com>
temoto
temoto approved these changes Sep 29, 2020
Copy link
Member

@temoto temoto left a comment

Hi and welcome.

Thank you. Sorry turns out WSSE wasn't working for a while.

I'm waiting for tests on CI and will merge this together with regression test on different branch because github won't let me push to yours. So don't pay much attention to PR status, your work is accepted keeping authorship.

@temoto temoto closed this Sep 29, 2020
@temoto
Copy link
Member

@temoto temoto commented Sep 29, 2020

Merged in 595e248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants