New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse auth headers using pyparsing instead of regexp #182
Conversation
@b-c-ds please take a look too, I can't add you to reviewers. |
b9a3c22
to
987e995
Compare
minor update in script/release to read |
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 76.16% 76.26% +0.10%
==========================================
Files 8 12 +4
Lines 2618 2667 +49
==========================================
+ Hits 1994 2034 +40
- Misses 624 633 +9
Continue to review full report at Codecov.
|
@temoto I'd never heard of the pyparsing module before... seems like a great alternative to regex. Looks good to me. |
Fixes CPU burn DoS by cubic complexity of whitespace matching in WWW_AUTH_RELAXED (default) regexp.
987e995
to
bd9ee25
Compare
Hello, do you know when you are planning to merge this? |
@b-c-ds hey, thanks for reminder, I was waiting for more reviews. This fix is released in 0.19.0. |
Fixes CPU burn DoS by cubic complexity of whitespace matching in
WWW_AUTH_RELAXED (default) regexp.