From 9d54e78494a1551f0a66e89c814f1598ba655759 Mon Sep 17 00:00:00 2001 From: John Doe Date: Fri, 6 Oct 2023 23:05:25 +0800 Subject: [PATCH] Handle responses in the reverse order from the requests --- lib/http/client.rb | 2 +- spec/lib/http/client_spec.rb | 38 ++++++++++++++++++++++++++++++++++++ 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/lib/http/client.rb b/lib/http/client.rb index 3ecb184a..af29f330 100644 --- a/lib/http/client.rb +++ b/lib/http/client.rb @@ -81,7 +81,7 @@ def perform(req, options) end res = build_response(req, options) - res = options.features.inject(res) do |response, (_name, feature)| + res = options.features.values.reverse.inject(res) do |response, feature| feature.wrap_response(response) end diff --git a/spec/lib/http/client_spec.rb b/spec/lib/http/client_spec.rb index 88822f3d..ed55c394 100644 --- a/spec/lib/http/client_spec.rb +++ b/spec/lib/http/client_spec.rb @@ -395,6 +395,44 @@ def on_error(request, error) end.to raise_error(HTTP::ConnectTimeoutError) expect(feature_instance.captured_error).to be_a(HTTP::ConnectTimeoutError) end + + it "handle responses in the reverse order from the requests" do + feature_class_order = + Class.new(HTTP::Feature) do + @order = [] + + class << self + attr_reader :order + end + + def initialize(id:) + @id = id + end + + def wrap_request(req) + self.class.order << "request.#{@id}" + req + end + + def wrap_response(res) + self.class.order << "response.#{@id}" + res + end + end + feature_instance_a = feature_class_order.new(:id => "a") + feature_instance_b = feature_class_order.new(:id => "b") + feature_instance_c = feature_class_order.new(:id => "c") + + client.use( + :test_feature_a => feature_instance_a, + :test_feature_b => feature_instance_b, + :test_feature_c => feature_instance_c + ).request(:get, dummy.endpoint) + + expect(feature_class_order.order).to eq( + ["request.a", "request.b", "request.c", "response.c", "response.b", "response.a"] + ) + end end end