New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis settings for Rubinius. #79

Merged
merged 1 commit into from Feb 10, 2014

Conversation

Projects
None yet
2 participants
@brixen
Contributor

brixen commented Feb 10, 2014

No description provided.

@ghost

This comment has been minimized.

ghost commented Feb 10, 2014

@brixen does rbx-2 make it unnecessary to include rubysl in your Gemfile?

@sferik

This comment has been minimized.

Contributor

sferik commented Feb 10, 2014

@robgleeson Apparently so. The Rubinius tests for this branch are passing on Travis CI.

sferik added a commit that referenced this pull request Feb 10, 2014

Merge pull request #79 from brixen/master
Update Travis settings for Rubinius.

@sferik sferik merged commit b9eb0bf into httprb:master Feb 10, 2014

1 check failed

default The Travis CI build could not complete due to an error
Details
@ghost

This comment has been minimized.

ghost commented Feb 10, 2014

interesting. thanks!

@ghost

This comment has been minimized.

ghost commented Feb 10, 2014

@sferik it looks like the http gem test helper doesn't initialize bundler through "bundler/setup" or use Bundler.require(…) to load Gemfile dependencies. maybe that's why it works? I saw a similar thing on a different repo a few days ago.
I looked @ https://github.com/tarcieri/http/blob/master/spec/spec_helper.rb

@brixen

This comment has been minimized.

Contributor

brixen commented Feb 10, 2014

@robgleeson the 'rbx-2' is to limit testing on Rubinius 2.x since there will be other versions of Rubinius > 2.x soon. This part is unrelated to loading gems.

I've changed Rubinius code loading to avoid Bundler stripping pre-installed gems. I'll be making a patch to Bundler so it will specifically consider pre-installed gems but in any case, Bundler will no longer prevent eg rubysl-securerandom or whatever from being loaded. I'm writing a Migrating from MRI guide that will cover this.

bf4 added a commit to whitequark/parser that referenced this pull request Feb 11, 2014

Specify TravisCI to run rbx-2 per @brixen
see http://www.benjaminfleischer.com/2013/12/05/testing-rubinius-on-travis-ci/ httprb/http#79 (comment)

The ‘rbx-2’ is to limit testing on Rubinius 2.x since there will be other versions of Rubinius > 2.x
@ghost

This comment has been minimized.

ghost commented Feb 12, 2014

@brixen cool, thanks! look forward to the guide.

ms-ati pushed a commit to ms-ati/docile that referenced this pull request Feb 21, 2014

Update Travis settings for Rubinius
Apparently, since rbx-2.2.5 you no longer need to require
gem rubysl or rubinius-coverage, and you must have travis
use the ruby named 'rbx-2'.

See
*  httprb/http#79
*  https://github.com/rubinius/rubinius/releases/tag/v2.2.5

wmoxam added a commit to wmoxam/phonie that referenced this pull request Mar 2, 2014

arlimus added a commit to gittalk/git-issues that referenced this pull request May 13, 2014

simplify rubinius testing to rbx-2
see: httprb/http#79
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>

arlimus added a commit to gittalk/git-issues that referenced this pull request May 13, 2014

simplify rubinius testing to rbx-2
see: httprb/http#79
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>

arlimus added a commit to arlimus/excon that referenced this pull request May 13, 2014

update travis settings to rubinius rbx-2
Recently TravisCI is experiencing issues with rbx-2.1.1 (bundler missing). Out of the possible fixes (including pre-installation of bundler) a recommended way is to specify rbx-2 in travis to set testing to Rubinius 2.x.

See also discussion here: httprb/http#79

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>

arlimus added a commit to arlimus/excon that referenced this pull request May 14, 2014

update travis settings to rubinius rbx-2
Recently TravisCI is experiencing issues with rbx-2.1.1 (bundler missing). Out of the possible fixes (including pre-installation of bundler) a recommended way is to specify rbx-2 in travis to set testing to Rubinius 2.x.

See also discussion here: httprb/http#79

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment