New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4 support. #266

Merged
merged 3 commits into from Nov 28, 2017

Conversation

Projects
None yet
5 participants
@MhdHejazi
Contributor

MhdHejazi commented Sep 21, 2017

No description provided.

@pakerwreah

reduce method does not expect return, instead you should modify the inout result

@pakerwreah

This comment has been minimized.

Show comment
Hide comment
@pakerwreah

pakerwreah Sep 28, 2017

Sorry... you can do both ways

output += mergedAttributes.reduce(into: "") { (r, v) in
        if let value = v.1 {
            r += " \(v.0)=\"\(value)\""
        }
    }

pakerwreah commented Sep 28, 2017

Sorry... you can do both ways

output += mergedAttributes.reduce(into: "") { (r, v) in
        if let value = v.1 {
            r += " \(v.0)=\"\(value)\""
        }
    }
@aeons

This comment has been minimized.

Show comment
Hide comment
@aeons

aeons Oct 30, 2017

@glock45 @julien-c is this something that could be merged? :)

aeons commented Oct 30, 2017

@glock45 @julien-c is this something that could be merged? :)

@Shashikant86

This comment has been minimized.

Show comment
Hide comment
@Shashikant86

Shashikant86 Nov 15, 2017

👍 +1 This really need to merge please !
Look forward to get this working with Swift 4

Shashikant86 commented Nov 15, 2017

👍 +1 This really need to merge please !
Look forward to get this working with Swift 4

@welljsjs welljsjs referenced this pull request Nov 22, 2017

Closed

Update to Swift 4 #276

@glock45 glock45 merged commit 647e5df into httpswift:stable Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment