Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be explicit about string case sensitivity #133

Closed
mnot opened this issue Aug 17, 2018 · 7 comments
Closed

Be explicit about string case sensitivity #133

mnot opened this issue Aug 17, 2018 · 7 comments
Assignees

Comments

@mnot
Copy link
Member

mnot commented Aug 17, 2018

Should we just adopt RFC7405 wherever we use a string?

@reschke
Copy link
Contributor

reschke commented Sep 19, 2018

Yes, I think that's what the IESG wants us to do. (We were directed to use it in alt-svc)

@mnot
Copy link
Member Author

mnot commented Nov 29, 2018

I've started a branch (mnot-133).

Question: do we want to convert things like this:

HTTP-name = %x48.54.54.50 ; HTTP

into:

http-name: %s"HTTP"

? We do that a fair amount for case-sensitive strings.

@mnot mnot self-assigned this Nov 29, 2018
@reschke
Copy link
Contributor

reschke commented Nov 29, 2018

Yes. Let me take care of this.

@royfielding
Copy link
Member

+1

@mnot mnot assigned reschke and unassigned mnot Dec 2, 2018
@mnot
Copy link
Member Author

mnot commented Dec 2, 2018

OK. I'll leave my branch there if you want to start with it; otherwise feel free to delete it.

@reschke
Copy link
Contributor

reschke commented Dec 2, 2018

FWIW, I'd prefer to do this only in the places where the string actually is case-sensitive.

reschke added a commit that referenced this issue Dec 4, 2018
reschke added a commit that referenced this issue Dec 4, 2018
Use "%s" notation for case-sensitive strings in ABNF (#133)
@reschke
Copy link
Contributor

reschke commented Feb 25, 2019

I guess I forgot to close the ticket.

@reschke reschke closed this as completed Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants