-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nit on CONNECT tunnel forwarding #170
Comments
|
Well spotted! I'd even suggest "to blindly forward bytes in both directions ...". Too often I see people who imagine that packet delimitation is respected on both sides of a proxy and I have to tell them that it's just a uninterrupted stream of bytes that each layer decides to delimit wherever it wants. |
|
I'd say that 7231 is self-consistent with the use of packet in 7230. If a change is needed, we should change wording consistently. Or, was this issue raised on the WIP core doc? |
|
@LPardue this issue is being raised on the WIP core doc. The same text does also exist in 7231, but I consider them to both be in error. While we're updating the text for the core doc, let's fix the text to be clearer. |
|
Thanks for the clarification @tfpauly, that sounds good to me. |
|
Fwiw, the HiNT draft uses the terminology: blind forwarding of IP payloads, UDP datagram payloads and TCP/IP packet payload. |
|
HTTP/3 says:
|
|
@MikeBishop that text looks good. Something along those lines, but that also works for HTTP/1.1, would be right for this core doc text. |
|
Maybe just replace "packets" with "data"? |
|
So as mentioned above in #327, while having a look at the latest draft I was struck again by this "packets" there, and even forgot about this old issue. Pinging again. I suggest that we change "forwarding of packets" with "forwarding of the byte stream" so that we can close these issues. |
The current section on CONNECT (7.3.6) in the semantics document refers to the proxy forwarding packets:
Since the proxy terminates TCP, there is no forwarding of IP packets, but rather the contents of the TCP streams.
The text was updated successfully, but these errors were encountered: