Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualified usage of private vs. shared caches #270

Closed
mpdude opened this issue Dec 4, 2019 · 5 comments · Fixed by #306
Closed

Qualified usage of private vs. shared caches #270

mpdude opened this issue Dec 4, 2019 · 5 comments · Fixed by #306

Comments

@mpdude
Copy link

@mpdude mpdude commented Dec 4, 2019

Section 3 of draft-ietf-httpbis-cache says:

A cache MUST NOT store a response to any request, unless: [...]
– the "private" response directive (see Section 5.2.2.6) does not appear in the response, if the cache is shared.

Section 5.2.2.6 then reads:

The "private" response directive indicates that the response message
is intended for a single user and MUST NOT be stored by a shared
cache. [...]

If the private response directive specifies one or more field-names,
this requirement is limited to the field-values associated with the
listed response header fields. That is, a shared cache MUST NOT
store the specified field-names(s), whereas it MAY store the
remainder of the response message.

To me, this last paragraph was a surprising read after Section 3 made a rather clear "if it is private and the cache is shared, don't cache it" statement.

Maybe it would help to amend the wording in Section 3 to read (emphasis mine)

the "private" response directive (see Section 5.2.2.6) does not appear in unqualified form in the response, if the cache is shared

@royfielding
Copy link
Member

@royfielding royfielding commented Dec 10, 2019

Right, though I expect "qualified" or "unqualified" is a little too vague to explain it. Maybe the "private" response directive without a list of field names?

@mnot mnot self-assigned this Feb 2, 2020
@mnot mnot added the caching label Feb 2, 2020
@mnot
Copy link
Member

@mnot mnot commented Feb 3, 2020

Currently, we have:

if the cache is shared: the "private" response directive is not present in the response (ref to section)

Proposal:

if the cache is shared: the "private" response directive, if present, allows the response to be stored (possibly with modifications; see ref to section)

@mpdude
Copy link
Author

@mpdude mpdude commented Feb 3, 2020

@mnot I am not sure I get you right :-/. Which section exactly are you referring to with your suggestion?

@mnot
Copy link
Member

@mnot mnot commented Feb 4, 2020

Sorry - here

@royfielding
Copy link
Member

@royfielding royfielding commented Feb 4, 2020

I think that would be sufficient to close. Maybe specifically say "allows the response to be stored by a shared cache (with modifications)".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants