Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to reserve field name and method name "*" #274

Closed
reschke opened this issue Jan 9, 2020 · 9 comments
Closed

need to reserve field name and method name "*" #274

reschke opened this issue Jan 9, 2020 · 9 comments
Assignees

Comments

@reschke
Copy link
Contributor

reschke commented Jan 9, 2020

A field name of "*" would clash with the definition of "Vary" (see #272).

A method name of "*" would clash with Access-Control-Request-Method (see https://fetch.spec.whatwg.org/#http-new-header-syntax) (ack @annevk)

@reschke reschke changed the title need to reserved field name and method name "*" need to reserve field name and method name "*" Jan 9, 2020
@reschke
Copy link
Contributor Author

reschke commented Jan 10, 2020

...or disallow registration.

@reschke
Copy link
Contributor Author

reschke commented Feb 2, 2020

partly blocked by #273

@reschke
Copy link
Contributor Author

reschke commented Jun 5, 2020

To "reserve" in the method registry, we'll need to add a "comments" column to the registry. Makes sense?

cc: @mnot

@annevk
Copy link
Contributor

annevk commented Jun 5, 2020

Would you leave Safe and Idempotent empty as well? Forbidding registration might be simpler?

@reschke
Copy link
Contributor Author

reschke commented Jun 5, 2020

Good question. Maybe "n/a"?

In any case, extending the registration procedure to disallow "*" works for me as well.

@mnot
Copy link
Member

mnot commented Jun 9, 2020

Disallowing registration is fine for me too. Should we also disallow registering it as a field name?

There are a few other ways we could do this that might be worth considering; e.g., we could require registered values to have at least two characters, or require registered values to begin with ALPHA. We already say:

While the field-name syntax is defined to allow any token character, in practice some implementations place limits on the characters they accept in field-names. To be interoperable, new field names should constrain themselves to alphanumeric characters, "-", and ".", and should begin with an alphanumeric character.

@reschke
Copy link
Contributor Author

reschke commented Jun 9, 2020

Disallowing registration is fine for me too. Should we also disallow registering it as a field name?

Yes, for consistency.

@mnot
Copy link
Member

mnot commented Jul 2, 2020

Discussed; put into the registry with a comment about why it's reserved; not safe or idempotent.

@reschke
Copy link
Contributor Author

reschke commented Jul 10, 2020

Note whatwg/fetch#1052

reschke added a commit that referenced this issue Jul 10, 2020
reschke added a commit that referenced this issue Jul 11, 2020
reserve "*" as field name and method name (#274)
@reschke reschke closed this as completed Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants