Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisiting Age error handling #471

Closed
mnot opened this issue Oct 9, 2020 · 0 comments · Fixed by #485
Closed

Revisiting Age error handling #471

mnot opened this issue Oct 9, 2020 · 0 comments · Fixed by #485

Comments

@mnot
Copy link
Member

mnot commented Oct 9, 2020

My tests for Age parsing seem to indicate we might want to reconsider how errors are handled.

Of implementations that honour Age (two don't):

  • none will consider 0, 0 invalid
  • none will consider 0 on two separate field lines invalid
  • none will consider a duplicated value on two lines to make the header invalid
  • if there are two Age header lines, all will consider only the first (and one, Safari, appears to use the min of them)
  • none considers a non-numeric value to be invalid
  • only Fastly and Firefox consider a non-negative integer to be invalid

... where invalid currently is required to be considered stale.

@mnot mnot added the caching label Oct 9, 2020
@mnot mnot self-assigned this Oct 18, 2020
mnot added a commit that referenced this issue Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant