Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If-Range: detecting Etag (vs Date) #570

Closed
reschke opened this issue Dec 7, 2020 · 0 comments
Closed

If-Range: detecting Etag (vs Date) #570

reschke opened this issue Dec 7, 2020 · 0 comments
Assignees
@reschke
Labels
has-proposal semantics

Comments

@reschke
Copy link
Contributor

reschke commented Dec 7, 2020

(this text is present in RFC 7233 as well)

"A valid entity-tag can be distinguished from a valid HTTP-date by examining the first two characters for a DQUOTE."

Hm, no. If we want to properly handle weak etags, we either need to inspect three characters (actually position 0 and 2) for DQUOTE, or check pos 0 for DQUOTE or pos 1 for "/".

If we're not interested in weak etags, checking the first character is sufficient.
@reschke reschke self-assigned this Dec 9, 2020
royfielding added a commit that referenced this issue Dec 9, 2020
@royfielding
Merge pull request #595 from httpwg/reschke-570
e003668 
fix an off-by-one bug about how many chars to consider when checking for etags (fixes #570)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reschke reschke

Labels
has-proposal semantics
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reschke