Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wordsmith automatic-link-editing guidance #976

Merged
merged 4 commits into from
Sep 10, 2021
Merged

Conversation

kaduk
Copy link
Contributor

@kaduk kaduk commented Sep 9, 2021

The current text of "ought to ... where possible" is easy to read
as saying "if you have the technical capability, do it".
There are, however, some subtleties, such as if you get the 308 response
over http-not-s, in which case the question of whether or not to
re-link is not so clear-cut.

Change from "where possible" to "where appropriate" to hint that there
is some logic needed here beyond "blindly accept".

(inspired by follow-up discussions from #914)

The current text of "ought to ... where possible" is easy to read
as saying "if you have the technical capability, do it".
There are, however, some subtleties, such as if you get the 308 response
over http-not-s, in which case the question of whether or not to
re-link is not so clear-cut.

Change from "where possible" to "where appropriate" to hint that there
is some logic needed here beyond "blindly accept".
Copy link
Member

@royfielding royfielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that begs a follow-on question about when it is appropriate.
I would be more comfortable with changing the entire sentence to be

   The server is suggesting that a user agent with link-editing capability
   can permanently replace references to the target URI with one of the
   new references sent by the server. However, this suggestion is usually
   ignored unless the user agent is actively editing references
   (e.g., engaged in authoring content), the connection is secured, and
   the origin server is a trusted authority for the content being edited.

@kaduk
Copy link
Contributor Author

kaduk commented Sep 10, 2021

I like Roy's version better than mine :)
I guess I was too conservative...

Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is good, but it needs to be done for 301 as well.

@reschke reschke closed this Sep 10, 2021
@reschke reschke reopened this Sep 10, 2021
@reschke reschke merged commit 1061387 into httpwg:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants