Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signatures: which parameters are tokens and which are quoted strings? #1307

Closed
llorllale opened this issue Oct 23, 2020 · 2 comments
Closed

Comments

@llorllale
Copy link

The signature header parameters are missing normative text on whether they are tokens or quoted strings. Suggest including normative text in each parameter's definition in section 4.1 clearly indicating whether they are a quoted-string or a token.

Related: in agreement with the topic in appendix B.1.2, the definition for keyId should at minimum define illegal characters that would present obstacles to reasonable parsing algorithms. Suggest adding normative text that this parameter MUST NOT include commas (","), at minimum.

@msporny
Copy link

msporny commented Oct 27, 2020

The original intent was that keyId is supposed to be a quoted string, because it could contain a URL, like a DID, or other random http URL.. Everything else that wasn't a number was supposed to be a quoted string as well. Agree that we should update the spec with this language making it more clear.

@jricher
Copy link
Contributor

jricher commented Apr 21, 2021

This should all be clear by the parameter definitions finalized in -03 and expanded in -04 -- in short, all the core ones are strings or numbers.

@jricher jricher closed this as completed Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants