Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean type character choice #784

Closed
martinthomson opened this issue Apr 3, 2019 · 15 comments
Closed

Boolean type character choice #784

martinthomson opened this issue Apr 3, 2019 · 15 comments

Comments

@martinthomson
Copy link
Contributor

This is going to sound like a bikeshed comment, but it's probably worth thinking about:

The current syntax uses ?T and ?F. In sitting through a presentation today, I realized that, from a distance, these two strings are hard to distinguish if the text is small enough. Looking at the QPACK table, I observe that existing header fields often use 1 to mean "true".

I propose that the syntax be changed to ?0 and ?1.

@martinthomson
Copy link
Contributor Author

Some feedback on this suggestion:

Mike West I suspect that Sec-Fetch-User is going to be the first boolean header hitting the wire. So. Hammer it out quickly, please (@mnot).
Mike West Ideally shipping in Chrome 75, which branches on the 18th.

@bsdphk
Copy link
Contributor

bsdphk commented Apr 3, 2019

No opinion.

@mnot
Copy link
Member

mnot commented Apr 3, 2019

I think the benefits aren't significant enough to change, given that it's already in use by some. Practically speaking, if you project HTTP headers that small, you're going to have lots of other problems too.

@wtarreau
Copy link

wtarreau commented Apr 3, 2019 via email

@mnot
Copy link
Member

mnot commented Apr 4, 2019

The non-english interpretation (of lack thereof) is persuasive here. @mikewest @jyasskin will changing this now cause any significant pain? Anyone else?

@jyasskin
Copy link
Contributor

jyasskin commented Apr 4, 2019

Signed Exchanges don't have any Boolean fields, and they're versioned anyway so we could change the parsing.

@mikewest
Copy link
Member

mikewest commented Apr 5, 2019

I'm happy for Sec-Fetch-User to serialize however you'd like. Pick something, tell me what it is, and I'll do it. Assuming it'll be ?1, I filed https://bugs.chromium.org/p/chromium/issues/detail?id=949894 and put up https://chromium-review.googlesource.com/c/chromium/src/+/1554484.

@bsdphk
Copy link
Contributor

bsdphk commented Apr 5, 2019

Still no opinion :-)

@mnot
Copy link
Member

mnot commented Apr 5, 2019

Let's do 0 / 1

@mikewest
Copy link
Member

mikewest commented Apr 5, 2019

With the ? prefix, though (?0/?1), right?

@mnot
Copy link
Member

mnot commented Apr 5, 2019

?1

@mikewest
Copy link
Member

mikewest commented Apr 5, 2019

(Maybe we can use 👍 and 👎 instead?)

@mikewest
Copy link
Member

mikewest commented Apr 5, 2019

(That was a joke, just in case it wasn't clear. ?1 is just as great as ?T, and I'll aim to land https://chromium-review.googlesource.com/c/chromium/src/+/1554484 to lock that into Chrome's implementation shortly.)

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Apr 5, 2019
Given the discussion in httpwg/http-extensions#784,
we should change our syntax.

Bug: 949894
Change-Id: Ic28ea999dbf2ff3cc6bd8a981be6e15eab397f64
@arturjanc
Copy link

The root cause here seems to be interplay between the similar visual appearance of the Greek digamma (Ϝ) and tau (Τ) which became a problem during the introduction of the West Saxon triewe and false to mean opposing values of truthiness (both introduced in the Old English revision, ca. AD 1200).

Rather than work around this legacy problem with the use of numerals, I would recommend reverting to the last character notation that didn't exhibit the problem -- Phoenician could be fine, though we might have to go as far back as Ugaritic.

@mikewest
Copy link
Member

mikewest commented Apr 5, 2019

@arturjanc: I am not changing Chrome to support Ugaritic. Or Phoenician. :)

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Apr 6, 2019
Given the discussion in httpwg/http-extensions#784,
we should change our syntax.

TBR=sky@chromium.org
Bug: 949894
Change-Id: Ic28ea999dbf2ff3cc6bd8a981be6e15eab397f64
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Apr 6, 2019
Given the discussion in httpwg/http-extensions#784,
we should change our syntax.

TBR=sky@chromium.org

Bug: 949894
Change-Id: Ic28ea999dbf2ff3cc6bd8a981be6e15eab397f64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554484
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648472}
aarongable pushed a commit to chromium/chromium that referenced this issue Apr 6, 2019
Given the discussion in httpwg/http-extensions#784,
we should change our syntax.

TBR=sky@chromium.org

Bug: 949894
Change-Id: Ic28ea999dbf2ff3cc6bd8a981be6e15eab397f64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554484
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648472}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Apr 6, 2019
Given the discussion in httpwg/http-extensions#784,
we should change our syntax.

TBR=sky@chromium.org

Bug: 949894
Change-Id: Ic28ea999dbf2ff3cc6bd8a981be6e15eab397f64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554484
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648472}
mikewest added a commit to w3c/webappsec-fetch-metadata that referenced this issue Apr 8, 2019
httpwg/http-extensions#784 changes `?T`
to `?1`. This patch follows along for the ride.
@mnot mnot closed this as completed in 69c2a55 Apr 10, 2019
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jun 5, 2019
…., a=testonly

Automatic update from web-platform-tests
Shift `Sec-Fetch-User` from `?T` to `?1`.

Given the discussion in httpwg/http-extensions#784,
we should change our syntax.

TBR=sky@chromium.org

Bug: 949894
Change-Id: Ic28ea999dbf2ff3cc6bd8a981be6e15eab397f64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554484
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648472}

--

wpt-commits: 923923a01f38577f471b1e613c4223a21ac027ff
wpt-pr: 16274
mykmelez pushed a commit to mykmelez/gecko that referenced this issue Jun 6, 2019
…., a=testonly

Automatic update from web-platform-tests
Shift `Sec-Fetch-User` from `?T` to `?1`.

Given the discussion in httpwg/http-extensions#784,
we should change our syntax.

TBR=sky@chromium.org

Bug: 949894
Change-Id: Ic28ea999dbf2ff3cc6bd8a981be6e15eab397f64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554484
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648472}

--

wpt-commits: 923923a01f38577f471b1e613c4223a21ac027ff
wpt-pr: 16274
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this issue Jul 23, 2019
Given the discussion in httpwg/http-extensions#784,
we should change our syntax.

TBR=sky@chromium.org

Bug: 949894
Change-Id: Ic28ea999dbf2ff3cc6bd8a981be6e15eab397f64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554484
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648472}
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 4, 2019
…., a=testonly

Automatic update from web-platform-tests
Shift `Sec-Fetch-User` from `?T` to `?1`.

Given the discussion in httpwg/http-extensions#784,
we should change our syntax.

TBR=skychromium.org

Bug: 949894
Change-Id: Ic28ea999dbf2ff3cc6bd8a981be6e15eab397f64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554484
Reviewed-by: Mike West <mkwstchromium.org>
Reviewed-by: Łukasz Anforowicz <lukaszachromium.org>
Commit-Queue: Mike West <mkwstchromium.org>
Cr-Commit-Position: refs/heads/master{#648472}

--

wpt-commits: 923923a01f38577f471b1e613c4223a21ac027ff
wpt-pr: 16274

UltraBlame original commit: 9333c2e7426aea61b5b21f20e57c7e2a8aed4024
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 4, 2019
…., a=testonly

Automatic update from web-platform-tests
Shift `Sec-Fetch-User` from `?T` to `?1`.

Given the discussion in httpwg/http-extensions#784,
we should change our syntax.

TBR=skychromium.org

Bug: 949894
Change-Id: Ic28ea999dbf2ff3cc6bd8a981be6e15eab397f64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554484
Reviewed-by: Mike West <mkwstchromium.org>
Reviewed-by: Łukasz Anforowicz <lukaszachromium.org>
Commit-Queue: Mike West <mkwstchromium.org>
Cr-Commit-Position: refs/heads/master{#648472}

--

wpt-commits: 923923a01f38577f471b1e613c4223a21ac027ff
wpt-pr: 16274

UltraBlame original commit: 9333c2e7426aea61b5b21f20e57c7e2a8aed4024
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 4, 2019
…., a=testonly

Automatic update from web-platform-tests
Shift `Sec-Fetch-User` from `?T` to `?1`.

Given the discussion in httpwg/http-extensions#784,
we should change our syntax.

TBR=skychromium.org

Bug: 949894
Change-Id: Ic28ea999dbf2ff3cc6bd8a981be6e15eab397f64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554484
Reviewed-by: Mike West <mkwstchromium.org>
Reviewed-by: Łukasz Anforowicz <lukaszachromium.org>
Commit-Queue: Mike West <mkwstchromium.org>
Cr-Commit-Position: refs/heads/master{#648472}

--

wpt-commits: 923923a01f38577f471b1e613c4223a21ac027ff
wpt-pr: 16274

UltraBlame original commit: 9333c2e7426aea61b5b21f20e57c7e2a8aed4024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

7 participants