Fixes #1337 - Align on HTML terminology for origins #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketaylr
commented
Feb 23, 2021
draft-ietf-httpbis-rfc6265bis.md
Outdated
| context" are defined in {{HTML}}. | ||
| "dedicated worker", "Document", "nested browsing context", "opaque origin", | ||
| "parent browsing context", "sandboxed origin browsing context flag", "shared | ||
| worker", "the worker's Documents", and "top-level browsing context", |
There was a problem hiding this comment.
gross, added in an extra space unintentionally 😞
miketaylr
force-pushed
the
issues/1337/1
branch
from
54bd550
to
5921b27
Compare
chlily1
reviewed
Feb 23, 2021
draft-ietf-httpbis-rfc6265bis.md
Outdated
| defined in {{HTML}}. | ||
| "dedicated worker", "Document", "nested browsing context", "opaque origin", | ||
| "parent browsing context", "sandboxed origin browsing context flag", "shared | ||
| worker", "the worker's Documents", and "top-level browsing context", |
There was a problem hiding this comment.
Super minor nit, the "and" should go right before the penultimate list element.
There was a problem hiding this comment.
oh, alphabetize fail. thanks.
|
Lgtm % nit |
miketaylr
force-pushed
the
issues/1337/1
branch
from
5921b27
to
305a9c0
Compare
|
Thanks @chlily1. I fixed the "English bug", feel free to merge when ready. |
miketaylr
force-pushed
the
issues/1337/1
branch
from
305a9c0
to
a1dc719
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like Steven got rid of "scheme/host/port triple" in #1348, so this just covers using "opaque origin".
PTAL @chlily1 @englehardt
(changelog commit will get pushed as soon as I have a PR URI)