-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize maximum Expires/Max-Age #1732
Conversation
The current spec is ambiguous on (1) what the maximum `Expires`/`Max-Age` attribute values can be and (2) whether the two must be consistent. This resolves both by requiring: (1) The maximum attribute value to be 400 days in the future or less (2) The maximum set for Max-Age and Expires be consistent. Why 400 days? The goal was to get close to 13 months so that functions one might perform annually (e.g., selecting insurance benefits for the next year) would work even as specific dates varied slightly. Since Expires deals in a specific date while Max-Age deals in delta-seconds, it seems ideal to select a value with an unambiguous meaning. If the cap were set at 13 months (instead of 400 days) in the future, the maximum TTL varies by the month it was set in and whether or not it's a leap year. closes #1600
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should primarily be up to the user agent, e.g. specified in the user agent's cookie policy (section 7.2). If the spec gives a specific limit, I think it should be a SHOULD rather than a MUST, since UAs are already doing their own thing.
See also section 7.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still in favor of making this 400 day limit a suggestion (i.e. a SHOULD) rather than a hard limit, but I'll defer to y'all on that. Added some phrasing suggestions, and +1 to Martin's suggestions.
Co-authored-by: Lily Chen <chlily@google.com>
Personally I think MUST makes sense as a max, with the existing carve-out that UAs can select something smaller if they want. So you end up with something like let spec_max_days = 400;
let ua_max_days = 28;
let clamped = Math.min(Math.max(0, ua_max_days), spec_max_days); |
|
Sure, I don't feel strongly about it. If there's to be a hard upper bound on a limit, 400 days seems reasonable. Separately, maybe there should be suggestion for a lower bound (a minimum capability that servers can expect but should not rely on, a la https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-rfc6265bis#section-6.1). Anyway, this lgtm if @sbingler and @miketaylr approve. |
|
I like the idea of a lower limit, how about seven days? One week seems like a reasonable expectation and there isn't a major browser violating that |
|
7 days would probably break a lot of sites. I can imagine browsers that might adopt that policy, but the limit in the spec needs to allow for common usage and people expect logins to last out a 7 day absence. What Mike says here is entirely reasonable. Set a mandatory maximum (400 days is fine), let browsers adjust that downward according to their policies. |
|
For my own sake I want to clarify I'm how I'm interpreting this proposed change and if it aligns with everyone else. After this change is made:
Sites are then free to set a cookie with a Does this sound agreeable? Does it align with everyone else's thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, modulo some pedantic nits.
|
I'm down, but with a single edit @sbingler:
|
I guess my sticking point is this: if we want to allow UAs to adjust |
Why? @martinthomson's suggestion that we "Set a mandatory maximum (400 days is fine), let browsers adjust that downward according to their policies." seems reasonable to me, and would allow this patch to address the concern actually expressed in #1600 around behavior at the upper limits. If a given browser wanted to cap |
|
+1 to @mikewest's comment, lower-bound requirements don't seem very useful to add to the spec. |
|
What if the lower bound was a |
This won't be committed until after shipping is approved. For now, this is just for vetting. This CL is a part of a series: (1) Add new UMA (2) Implement limit behind flag (3) Enable by default Spec: httpwg/http-extensions#1732 COMMIT: false Bug: 1264458 Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311
This won't be committed until after shipping is approved. For now, this is just for vetting. This CL is a part of a series: (1) Add new UMA (2) Implement limit behind flag (3) Enable by default Spec: httpwg/http-extensions#1732 COMMIT: false Bug: 1264458 Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311
This won't be committed until after shipping is approved. For now, this is just for vetting. This CL is a part of a series: (1) Add new UMA (2) Implement limit behind flag (3) Enable by default Spec: httpwg/http-extensions#1732 COMMIT: false Bug: 1264458 Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311
This won't be committed until after shipping is approved. For now, this is just for vetting. This CL is a part of a series: (1) Add new UMA (2) Implement limit behind flag (3) Enable by default Spec: httpwg/http-extensions#1732 COMMIT: false Bug: 1264458 Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311
This won't be committed until after shipping is approved. For now, this is just for vetting. This CL is a part of a series: (1) Add new UMA (2) Implement limit behind flag (3) Enable by default Spec: httpwg/http-extensions#1732 COMMIT: false Bug: 1264458 Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311
This won't be committed until after shipping is approved. For now, this is just for vetting. This CL is a part of a series: (1) Add new UMA (2) Implement limit behind flag (3) Enable by default Spec: httpwg/http-extensions#1732 Bug: 1264458 Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Auto-Submit: Ari Chivukula <arichiv@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Ari Chivukula <arichiv@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1003286}
This won't be committed until after shipping is approved. For now, this is just for vetting. This CL is a part of a series: (1) Add new UMA (2) Implement limit behind flag (3) Enable by default Spec: httpwg/http-extensions#1732 Bug: 1264458 Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Auto-Submit: Ari Chivukula <arichiv@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Ari Chivukula <arichiv@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1003286}
This won't be committed until after shipping is approved. For now, this is just for vetting. This CL is a part of a series: (1) Add new UMA (2) Implement limit behind flag (3) Enable by default Spec: httpwg/http-extensions#1732 Bug: 1264458 Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Auto-Submit: Ari Chivukula <arichiv@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Ari Chivukula <arichiv@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1003286}
This reverts commit caff7911aeddc8d231dc335715d1dda404320f67. Reason for revert: Failing multiple bots Original change's description: > [Cookie Expires/Max-Age Upper Limit] (3) Enable by default > > This won't be committed until after shipping is approved. > For now, this is just for vetting. > > This CL is a part of a series: > (1) Add new UMA > (2) Implement limit behind flag > (3) Enable by default > > Spec: > httpwg/http-extensions#1732 > > Bug: 1264458 > Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Auto-Submit: Ari Chivukula <arichiv@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Steven Bingler <bingler@chromium.org> > Commit-Queue: Ari Chivukula <arichiv@chromium.org> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1003286} Bug: 1264458, 1325493 Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321 Commit-Queue: Lijin Shen <lazzzis@google.com> Owners-Override: Lijin Shen <lazzzis@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1003366}
This reverts commit caff7911aeddc8d231dc335715d1dda404320f67. Reason for revert: Failing multiple bots Original change's description: > [Cookie Expires/Max-Age Upper Limit] (3) Enable by default > > This won't be committed until after shipping is approved. > For now, this is just for vetting. > > This CL is a part of a series: > (1) Add new UMA > (2) Implement limit behind flag > (3) Enable by default > > Spec: > httpwg/http-extensions#1732 > > Bug: 1264458 > Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Auto-Submit: Ari Chivukula <arichiv@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Steven Bingler <bingler@chromium.org> > Commit-Queue: Ari Chivukula <arichiv@chromium.org> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1003286} Bug: 1264458, 1325493 Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321 Commit-Queue: Lijin Shen <lazzzis@google.com> Owners-Override: Lijin Shen <lazzzis@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1003366}
This reverts commit c8b12486f3e497a3477614f3c2d9fc0d66f9d568. Reason for revert: Fixing broken bots, underlying change is correct one Original change's description: > Revert "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default" > > This reverts commit caff7911aeddc8d231dc335715d1dda404320f67. > > Reason for revert: Failing multiple bots > > Original change's description: > > [Cookie Expires/Max-Age Upper Limit] (3) Enable by default > > > > This won't be committed until after shipping is approved. > > For now, this is just for vetting. > > > > This CL is a part of a series: > > (1) Add new UMA > > (2) Implement limit behind flag > > (3) Enable by default > > > > Spec: > > httpwg/http-extensions#1732 > > > > Bug: 1264458 > > Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 > > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > > Reviewed-by: Clark DuVall <cduvall@chromium.org> > > Auto-Submit: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Reviewed-by: Steven Bingler <bingler@chromium.org> > > Commit-Queue: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1003286} > > Bug: 1264458, 1325493 > Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321 > Commit-Queue: Lijin Shen <lazzzis@google.com> > Owners-Override: Lijin Shen <lazzzis@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1003366} Bug: 1264458, 1325493 Change-Id: Id9a059fe1c9755420aacc5fb0fc428883259facf
This reverts commit c8b12486f3e497a3477614f3c2d9fc0d66f9d568. Reason for revert: Fixing broken bots, underlying change is correct one Original change's description: > Revert "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default" > > This reverts commit caff7911aeddc8d231dc335715d1dda404320f67. > > Reason for revert: Failing multiple bots > > Original change's description: > > [Cookie Expires/Max-Age Upper Limit] (3) Enable by default > > > > This won't be committed until after shipping is approved. > > For now, this is just for vetting. > > > > This CL is a part of a series: > > (1) Add new UMA > > (2) Implement limit behind flag > > (3) Enable by default > > > > Spec: > > httpwg/http-extensions#1732 > > > > Bug: 1264458 > > Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 > > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > > Reviewed-by: Clark DuVall <cduvall@chromium.org> > > Auto-Submit: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Reviewed-by: Steven Bingler <bingler@chromium.org> > > Commit-Queue: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1003286} > > Bug: 1264458, 1325493 > Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321 > Commit-Queue: Lijin Shen <lazzzis@google.com> > Owners-Override: Lijin Shen <lazzzis@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1003366} Bug: 1264458, 1325493 Change-Id: Id9a059fe1c9755420aacc5fb0fc428883259facf
This reverts commit c8b12486f3e497a3477614f3c2d9fc0d66f9d568. Reason for revert: Fixing broken bots, underlying change is correct one Original change's description: > Revert "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default" > > This reverts commit caff7911aeddc8d231dc335715d1dda404320f67. > > Reason for revert: Failing multiple bots > > Original change's description: > > [Cookie Expires/Max-Age Upper Limit] (3) Enable by default > > > > This won't be committed until after shipping is approved. > > For now, this is just for vetting. > > > > This CL is a part of a series: > > (1) Add new UMA > > (2) Implement limit behind flag > > (3) Enable by default > > > > Spec: > > httpwg/http-extensions#1732 > > > > Bug: 1264458 > > Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 > > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > > Reviewed-by: Clark DuVall <cduvall@chromium.org> > > Auto-Submit: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Reviewed-by: Steven Bingler <bingler@chromium.org> > > Commit-Queue: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1003286} > > Bug: 1264458, 1325493 > Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321 > Commit-Queue: Lijin Shen <lazzzis@google.com> > Owners-Override: Lijin Shen <lazzzis@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1003366} Bug: 1264458, 1325493 Change-Id: Id9a059fe1c9755420aacc5fb0fc428883259facf
This reverts commit c8b12486f3e497a3477614f3c2d9fc0d66f9d568. Reason for revert: Fixing broken bots, underlying change is correct one Original change's description: > Revert "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default" > > This reverts commit caff7911aeddc8d231dc335715d1dda404320f67. > > Reason for revert: Failing multiple bots > > Original change's description: > > [Cookie Expires/Max-Age Upper Limit] (3) Enable by default > > > > This won't be committed until after shipping is approved. > > For now, this is just for vetting. > > > > This CL is a part of a series: > > (1) Add new UMA > > (2) Implement limit behind flag > > (3) Enable by default > > > > Spec: > > httpwg/http-extensions#1732 > > > > Bug: 1264458 > > Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 > > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > > Reviewed-by: Clark DuVall <cduvall@chromium.org> > > Auto-Submit: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Reviewed-by: Steven Bingler <bingler@chromium.org> > > Commit-Queue: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1003286} > > Bug: 1264458, 1325493 > Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321 > Commit-Queue: Lijin Shen <lazzzis@google.com> > Owners-Override: Lijin Shen <lazzzis@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1003366} Bug: 1264458, 1325493 Change-Id: Id9a059fe1c9755420aacc5fb0fc428883259facf
This reverts commit c8b12486f3e497a3477614f3c2d9fc0d66f9d568. Reason for revert: Fixing broken bots, underlying change is correct one Original change's description: > Revert "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default" > > This reverts commit caff7911aeddc8d231dc335715d1dda404320f67. > > Reason for revert: Failing multiple bots > > Original change's description: > > [Cookie Expires/Max-Age Upper Limit] (3) Enable by default > > > > This won't be committed until after shipping is approved. > > For now, this is just for vetting. > > > > This CL is a part of a series: > > (1) Add new UMA > > (2) Implement limit behind flag > > (3) Enable by default > > > > Spec: > > httpwg/http-extensions#1732 > > > > Bug: 1264458 > > Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 > > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > > Reviewed-by: Clark DuVall <cduvall@chromium.org> > > Auto-Submit: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Reviewed-by: Steven Bingler <bingler@chromium.org> > > Commit-Queue: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1003286} > > Bug: 1264458, 1325493 > Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321 > Commit-Queue: Lijin Shen <lazzzis@google.com> > Owners-Override: Lijin Shen <lazzzis@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1003366} Bug: 1264458, 1325493 Change-Id: Id9a059fe1c9755420aacc5fb0fc428883259facf
This reverts commit c8b12486f3e497a3477614f3c2d9fc0d66f9d568. Reason for revert: Fixing broken bots, underlying change is correct one Original change's description: > Revert "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default" > > This reverts commit caff7911aeddc8d231dc335715d1dda404320f67. > > Reason for revert: Failing multiple bots > > Original change's description: > > [Cookie Expires/Max-Age Upper Limit] (3) Enable by default > > > > This won't be committed until after shipping is approved. > > For now, this is just for vetting. > > > > This CL is a part of a series: > > (1) Add new UMA > > (2) Implement limit behind flag > > (3) Enable by default > > > > Spec: > > httpwg/http-extensions#1732 > > > > Bug: 1264458 > > Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 > > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > > Reviewed-by: Clark DuVall <cduvall@chromium.org> > > Auto-Submit: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Reviewed-by: Steven Bingler <bingler@chromium.org> > > Commit-Queue: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1003286} > > Bug: 1264458, 1325493 > Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321 > Commit-Queue: Lijin Shen <lazzzis@google.com> > Owners-Override: Lijin Shen <lazzzis@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1003366} Bug: 1264458, 1325493 Change-Id: Id9a059fe1c9755420aacc5fb0fc428883259facf
This reverts commit c8b12486f3e497a3477614f3c2d9fc0d66f9d568. Reason for revert: Fixing broken bots, underlying change is correct one Original change's description: > Revert "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default" > > This reverts commit caff7911aeddc8d231dc335715d1dda404320f67. > > Reason for revert: Failing multiple bots > > Original change's description: > > [Cookie Expires/Max-Age Upper Limit] (3) Enable by default > > > > This won't be committed until after shipping is approved. > > For now, this is just for vetting. > > > > This CL is a part of a series: > > (1) Add new UMA > > (2) Implement limit behind flag > > (3) Enable by default > > > > Spec: > > httpwg/http-extensions#1732 > > > > Bug: 1264458 > > Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 > > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > > Reviewed-by: Clark DuVall <cduvall@chromium.org> > > Auto-Submit: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Reviewed-by: Steven Bingler <bingler@chromium.org> > > Commit-Queue: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1003286} > > Bug: 1264458, 1325493 > Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321 > Commit-Queue: Lijin Shen <lazzzis@google.com> > Owners-Override: Lijin Shen <lazzzis@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1003366} Bug: 1264458, 1325493 Change-Id: Id9a059fe1c9755420aacc5fb0fc428883259facf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645552 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Ari Chivukula <arichiv@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/main@{#1004201}
This reverts commit c8b12486f3e497a3477614f3c2d9fc0d66f9d568. Reason for revert: Fixing broken bots, underlying change is correct one Original change's description: > Revert "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default" > > This reverts commit caff7911aeddc8d231dc335715d1dda404320f67. > > Reason for revert: Failing multiple bots > > Original change's description: > > [Cookie Expires/Max-Age Upper Limit] (3) Enable by default > > > > This won't be committed until after shipping is approved. > > For now, this is just for vetting. > > > > This CL is a part of a series: > > (1) Add new UMA > > (2) Implement limit behind flag > > (3) Enable by default > > > > Spec: > > httpwg/http-extensions#1732 > > > > Bug: 1264458 > > Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 > > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > > Reviewed-by: Clark DuVall <cduvall@chromium.org> > > Auto-Submit: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Reviewed-by: Steven Bingler <bingler@chromium.org> > > Commit-Queue: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1003286} > > Bug: 1264458, 1325493 > Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321 > Commit-Queue: Lijin Shen <lazzzis@google.com> > Owners-Override: Lijin Shen <lazzzis@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1003366} Bug: 1264458, 1325493 Change-Id: Id9a059fe1c9755420aacc5fb0fc428883259facf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645552 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Ari Chivukula <arichiv@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/main@{#1004201}
… Enable by default, a=testonly Automatic update from web-platform-tests [Cookie Expires/Max-Age Upper Limit] (3) Enable by default This won't be committed until after shipping is approved. For now, this is just for vetting. This CL is a part of a series: (1) Add new UMA (2) Implement limit behind flag (3) Enable by default Spec: httpwg/http-extensions#1732 Bug: 1264458 Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Auto-Submit: Ari Chivukula <arichiv@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Ari Chivukula <arichiv@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1003286} -- wpt-commits: ebbd0188cfd7d3448542a757b523a2a5147b5ef1 wpt-pr: 33454
…mit] (3) Enable by default", a=testonly Automatic update from web-platform-tests Revert "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default" This reverts commit caff7911aeddc8d231dc335715d1dda404320f67. Reason for revert: Failing multiple bots Original change's description: > [Cookie Expires/Max-Age Upper Limit] (3) Enable by default > > This won't be committed until after shipping is approved. > For now, this is just for vetting. > > This CL is a part of a series: > (1) Add new UMA > (2) Implement limit behind flag > (3) Enable by default > > Spec: > httpwg/http-extensions#1732 > > Bug: 1264458 > Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Auto-Submit: Ari Chivukula <arichiv@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Steven Bingler <bingler@chromium.org> > Commit-Queue: Ari Chivukula <arichiv@chromium.org> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1003286} Bug: 1264458, 1325493 Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321 Commit-Queue: Lijin Shen <lazzzis@google.com> Owners-Override: Lijin Shen <lazzzis@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1003366} -- wpt-commits: 730cef4a2fbf9bc1b70834ece165f02c7ed280e1 wpt-pr: 34063
…mit] (3) Enable by default", a=testonly Automatic update from web-platform-tests Reland "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default" This reverts commit c8b12486f3e497a3477614f3c2d9fc0d66f9d568. Reason for revert: Fixing broken bots, underlying change is correct one Original change's description: > Revert "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default" > > This reverts commit caff7911aeddc8d231dc335715d1dda404320f67. > > Reason for revert: Failing multiple bots > > Original change's description: > > [Cookie Expires/Max-Age Upper Limit] (3) Enable by default > > > > This won't be committed until after shipping is approved. > > For now, this is just for vetting. > > > > This CL is a part of a series: > > (1) Add new UMA > > (2) Implement limit behind flag > > (3) Enable by default > > > > Spec: > > httpwg/http-extensions#1732 > > > > Bug: 1264458 > > Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 > > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > > Reviewed-by: Clark DuVall <cduvall@chromium.org> > > Auto-Submit: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Reviewed-by: Steven Bingler <bingler@chromium.org> > > Commit-Queue: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1003286} > > Bug: 1264458, 1325493 > Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321 > Commit-Queue: Lijin Shen <lazzzis@google.com> > Owners-Override: Lijin Shen <lazzzis@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1003366} Bug: 1264458, 1325493 Change-Id: Id9a059fe1c9755420aacc5fb0fc428883259facf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645552 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Ari Chivukula <arichiv@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/main@{#1004201} -- wpt-commits: 4d6b7ec2c615f8736db9cee73deaacdaf2c17490 wpt-pr: 34064
… Enable by default, a=testonly Automatic update from web-platform-tests [Cookie Expires/Max-Age Upper Limit] (3) Enable by default This won't be committed until after shipping is approved. For now, this is just for vetting. This CL is a part of a series: (1) Add new UMA (2) Implement limit behind flag (3) Enable by default Spec: httpwg/http-extensions#1732 Bug: 1264458 Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Auto-Submit: Ari Chivukula <arichiv@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Ari Chivukula <arichiv@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1003286} -- wpt-commits: ebbd0188cfd7d3448542a757b523a2a5147b5ef1 wpt-pr: 33454
…mit] (3) Enable by default", a=testonly Automatic update from web-platform-tests Revert "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default" This reverts commit caff7911aeddc8d231dc335715d1dda404320f67. Reason for revert: Failing multiple bots Original change's description: > [Cookie Expires/Max-Age Upper Limit] (3) Enable by default > > This won't be committed until after shipping is approved. > For now, this is just for vetting. > > This CL is a part of a series: > (1) Add new UMA > (2) Implement limit behind flag > (3) Enable by default > > Spec: > httpwg/http-extensions#1732 > > Bug: 1264458 > Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Auto-Submit: Ari Chivukula <arichiv@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Steven Bingler <bingler@chromium.org> > Commit-Queue: Ari Chivukula <arichiv@chromium.org> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1003286} Bug: 1264458, 1325493 Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321 Commit-Queue: Lijin Shen <lazzzis@google.com> Owners-Override: Lijin Shen <lazzzis@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1003366} -- wpt-commits: 730cef4a2fbf9bc1b70834ece165f02c7ed280e1 wpt-pr: 34063
…mit] (3) Enable by default", a=testonly Automatic update from web-platform-tests Reland "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default" This reverts commit c8b12486f3e497a3477614f3c2d9fc0d66f9d568. Reason for revert: Fixing broken bots, underlying change is correct one Original change's description: > Revert "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default" > > This reverts commit caff7911aeddc8d231dc335715d1dda404320f67. > > Reason for revert: Failing multiple bots > > Original change's description: > > [Cookie Expires/Max-Age Upper Limit] (3) Enable by default > > > > This won't be committed until after shipping is approved. > > For now, this is just for vetting. > > > > This CL is a part of a series: > > (1) Add new UMA > > (2) Implement limit behind flag > > (3) Enable by default > > > > Spec: > > httpwg/http-extensions#1732 > > > > Bug: 1264458 > > Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 > > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > > Reviewed-by: Clark DuVall <cduvall@chromium.org> > > Auto-Submit: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Reviewed-by: Steven Bingler <bingler@chromium.org> > > Commit-Queue: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1003286} > > Bug: 1264458, 1325493 > Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321 > Commit-Queue: Lijin Shen <lazzzis@google.com> > Owners-Override: Lijin Shen <lazzzis@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1003366} Bug: 1264458, 1325493 Change-Id: Id9a059fe1c9755420aacc5fb0fc428883259facf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645552 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Ari Chivukula <arichiv@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/main@{#1004201} -- wpt-commits: 4d6b7ec2c615f8736db9cee73deaacdaf2c17490 wpt-pr: 34064
This won't be committed until after shipping is approved. For now, this is just for vetting. This CL is a part of a series: (1) Add new UMA (2) Implement limit behind flag (3) Enable by default Spec: httpwg/http-extensions#1732 Bug: 1264458 Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Auto-Submit: Ari Chivukula <arichiv@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Ari Chivukula <arichiv@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1003286} NOKEYCHECK=True GitOrigin-RevId: caff7911aeddc8d231dc335715d1dda404320f67
This reverts commit caff7911aeddc8d231dc335715d1dda404320f67. Reason for revert: Failing multiple bots Original change's description: > [Cookie Expires/Max-Age Upper Limit] (3) Enable by default > > This won't be committed until after shipping is approved. > For now, this is just for vetting. > > This CL is a part of a series: > (1) Add new UMA > (2) Implement limit behind flag > (3) Enable by default > > Spec: > httpwg/http-extensions#1732 > > Bug: 1264458 > Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Auto-Submit: Ari Chivukula <arichiv@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Steven Bingler <bingler@chromium.org> > Commit-Queue: Ari Chivukula <arichiv@chromium.org> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1003286} Bug: 1264458, 1325493 Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321 Commit-Queue: Lijin Shen <lazzzis@google.com> Owners-Override: Lijin Shen <lazzzis@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1003366} NOKEYCHECK=True GitOrigin-RevId: c8b12486f3e497a3477614f3c2d9fc0d66f9d568
This reverts commit c8b12486f3e497a3477614f3c2d9fc0d66f9d568. Reason for revert: Fixing broken bots, underlying change is correct one Original change's description: > Revert "[Cookie Expires/Max-Age Upper Limit] (3) Enable by default" > > This reverts commit caff7911aeddc8d231dc335715d1dda404320f67. > > Reason for revert: Failing multiple bots > > Original change's description: > > [Cookie Expires/Max-Age Upper Limit] (3) Enable by default > > > > This won't be committed until after shipping is approved. > > For now, this is just for vetting. > > > > This CL is a part of a series: > > (1) Add new UMA > > (2) Implement limit behind flag > > (3) Enable by default > > > > Spec: > > httpwg/http-extensions#1732 > > > > Bug: 1264458 > > Change-Id: Idc0469d260c4a5706a9c64feec9af5a0f490d311 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561385 > > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > > Reviewed-by: Clark DuVall <cduvall@chromium.org> > > Auto-Submit: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Reviewed-by: Steven Bingler <bingler@chromium.org> > > Commit-Queue: Ari Chivukula <arichiv@chromium.org> > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1003286} > > Bug: 1264458, 1325493 > Change-Id: Ia10ffe2f5b6b21a6de3f6bc3a3014510ac3a0e68 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648321 > Commit-Queue: Lijin Shen <lazzzis@google.com> > Owners-Override: Lijin Shen <lazzzis@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1003366} Bug: 1264458, 1325493 Change-Id: Id9a059fe1c9755420aacc5fb0fc428883259facf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645552 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Ari Chivukula <arichiv@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/main@{#1004201} NOKEYCHECK=True GitOrigin-RevId: aaa5d2b55478eac2ee642653dcd77a50ac3faff6
The current spec is ambiguous on (1) what the maximum
Expires/Max-Ageattribute values can be and (2) whether the two must be consistent. This resolves both by requiring:Why 400 days? The goal was to get close to 13 months so that functions one might perform annually (e.g., selecting insurance benefits for the next year) would work even as specific dates varied slightly. Since
Expiresdeals in a specific date whileMax-Agedeals in delta-seconds, it seems ideal to select a value with an unambiguous meaning. If the cap were set at 13 months (instead of 400 days) in the future, the maximum TTL varies by the month it was set in and whether or not it's a leap year.Who is compliant with this modification? Currently, only Safari sets a cap lower than 400 days (one week).
closes #1600