Flexibility in Cookie Expiry Timeline #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@johnwilander pointed out that there were use cases in which cookie expiry limits over 400 days made sense (https://lists.webkit.org/pipermail/webkit-dev/2022-January/032096.html).
arichiv
requested review from
chlily1,
mikewest and
johnwilander
as code owners
|
@sbingler @miketaylr for review |
sbingler
reviewed
Feb 17, 2022
Co-authored-by: Mike West <mike@mikewest.org>
sbingler
reviewed
Feb 23, 2022
|
Whoops, got lost in the shuffle. LGTM with a small suggestion on your example |
Co-authored-by: Steven Bingler <bingler@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@johnwilander pointed out that there were use cases in which cookie expiry limits over 400 days made sense (https://lists.webkit.org/pipermail/webkit-dev/2022-January/032096.html).