New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discuss limitations on types based on field def #2396
Conversation
Co-authored-by: Julian Reschke <julian.reschke@gmx.de>
It's likely because the field is ignored when parsing fails, but 8941 s 2 allows a field to specify other error handling behaivour. |
How so? 8941, Section 4.2 says:
|
Section 2 has a bit more nuance:
|
You refer to:
? My reading is that this applies to the preceding text about what happens when parsing does not fail, but additional constraints are not met. If this is not the case, we should consider this to be an inconsistency in requirements and treat it as spec bug. EDIT: opened #2399 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "likely discarded" is very misleading; it's a requirement to discard.
Co-authored-by: Julian Reschke <julian.reschke@gmx.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion you might consider... I think that it would be helpful to include a more complete example here.
There is a hazard here in that any inconsistency how processing occurs creates interesting effects. That is, the field is destroyed if a Date if observed. That might lead to Heisenbugs.
Let's say you have a WAF that uses SF to parse, but it only looks at certain things. Maybe it doesn't look at parameters. This might ignore a Date on something like:
Example: ?0;t=@4098543601
Code that processes the t
parameter might (rightfully) discard the field if it sees the Date.
Co-authored-by: Martin Thomson <mt@lowentropy.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(with two nits)
Co-authored-by: Julian Reschke <julian.reschke@gmx.de>
Fixes #2393.