Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove image-related Client Hints #775

Merged
merged 3 commits into from Mar 11, 2019

Conversation

Projects
None yet
2 participants
@yoavweiss
Copy link
Contributor

commented Mar 8, 2019

As previously discussed, the current state where some CH hints are defined in the IETF draft and some in accompanying specifications is confusing. Furthermore, defining the image related hints in web specifications would be a better fit, as they have direct implications to image processing there.

This PR removes those hints from the IETF draft. This hints are being added to the HTML specification as part of a larger Client Hints related PR.

@yoavweiss

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

@igrigorik
Copy link
Member

left a comment

Overall, lgtm. A couple quick comments..

Show resolved Hide resolved draft-ietf-httpbis-client-hints.md Outdated
Show resolved Hide resolved draft-ietf-httpbis-client-hints.md Outdated
@igrigorik
Copy link
Member

left a comment

👍

This may be a separate PR: should we document guidance on naming hints? In the examples we use Sec-CH- prefix and it seems like something worth documenting in the spec, and explain why.

@igrigorik igrigorik merged commit 08a8f12 into httpwg:master Mar 11, 2019

@igrigorik

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

Merging.

@mnot if you have any nits or suggestions, please chime in here and we can address in a separate PR. In the meantime, I'll push a new draft so we have the updated version to discuss at upcoming IETF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.