Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client advertising settings during Upgrade dance #51

Closed
OsamaM opened this issue Mar 15, 2013 · 2 comments
Closed

Client advertising settings during Upgrade dance #51

OsamaM opened this issue Mar 15, 2013 · 2 comments

Comments

@OsamaM
Copy link

@OsamaM OsamaM commented Mar 15, 2013

This issue is to track whether the client should advertise its settings (e.g. contents of SETTINGS frame) as part of the Upgrade GET (e.g. as HTTP/1.1 headers in the GET request).

Normally, the first HTTP/2.0 frame the client emits is the SETTINGS frame. This means the server will receive the client's settings before getting the SYN_STREAM from the client. However, in the Upgrade Dance the server receives the GET and has to respond with a 101 HTTP/1.1 response followed by the HTTP/2.0 SYN_REPLY.

The ugliness here is that the server will be in a situation where it has to send the SYN_REPLY (and possibly DATA frames and possibly start push streams) without knowing the client's settings. This means the server may blow the client’s flow control buffers, or emit a pushed stream even though the client is incapable of processing pushed streams, etc.

If we include the settings as part of the initial Upgrade GET then

  1. Server receives the pre-requisite initials settings and the initial GET request in a single package. Makes life simpler.
  2. Brings us to parity with the SSL route where the server will have the cilent's SETTINGS before it starts working on the initial request.
@mnot
Copy link
Member

@mnot mnot commented Jun 13, 2013

Discussed at SF Interim; targetting 1st implementation draft. Gabriel to make proposal.

GabrielMontenegro added a commit to GabrielMontenegro/http2-spec that referenced this issue Jun 19, 2013
httpwg#51:Client advertising settings during Upgrade dance
httpwg#51
@OsamaM
Copy link
Author

@OsamaM OsamaM commented Jul 20, 2013

Addressed via "HTTP2-Settings Header Field" section.

@OsamaM OsamaM closed this Jul 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants