Kaduk IESG feedback #1012
Closed
Kaduk IESG feedback #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnot
reviewed
Jan 7, 2022
Lukasa
reviewed
Jan 7, 2022
| also carrying control data associated with the message in the form of <xref target="PseudoHeaderFields">pseudo-header fields</xref> that use the same format as a | ||
| field line. | ||
| A field section consists of exactly one field block. Each field block carries the | ||
| compressed bytes of a single field section. Header sections also include control data |
There was a problem hiding this comment.
Hmm, this section reads strangely to me. Field sections are made up of field blocks which carry the compressed bytes of field sections? This feels a little recursive.
Do we have a clearer way to express this idea?
There was a problem hiding this comment.
I gave it a try. I had to submit a version, so I went with this:
Each field block carries all of the compressed field lines of a single field section.
There was a problem hiding this comment.
I think that would work much better.
|
Merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of small changes here, though nothing of any real consequence, I believe.