Add some warnings about concatenation of URI parts #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's going to happen anyway, but we can at least warn people. This doesn't specify what validation is necessary in any detail (that is somewhat involved), it only notes that simple concatenation is almost certainly not secure. Closes httpwg#1015.
martinthomson
force-pushed
the
combine-at-own-risk
branch
from
d6bee81
to
946b06b
Compare
wtarreau
reviewed
Jan 13, 2022
draft-ietf-httpbis-http2bis.xml
Outdated
| <xref target="HttpHeaders"/> does not include specific rules for validation of | ||
| pseudo-header fields. If the values of these fields are used, additional validation is | ||
| necessary. This is particularly important where <tt>:scheme</tt>, <tt>:authority</tt>, | ||
| and <tt>:path</tt> are combined to form a single URI string (<xref target="RFC3986"/>). |
There was a problem hiding this comment.
maybe add "and/or when combined with :methodto rebuild a request line" since all implementations were caught with a space in that one.
There was a problem hiding this comment.
Thanks Willy, I've added a sentence.
|
OK that's fine by me. At least they're warned, and those who want to know more will easily find info on the subject, including these conversations. Thank you Martin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's going to happen anyway, but we can at least warn people.
This doesn't specify what validation is necessary in any detail (that is
somewhat involved), it only notes that simple concatenation is almost
certainly not secure.
Closes #1015.