Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Secrets + Public Key to Repository #1446

merged 3 commits into from Jun 21, 2022


Copy link

@maddymanu maddymanu commented Apr 27, 2022


Hey everyone!! I added support for creating secrets for a given repository using the API.
The relevant docs are here:

It also needed the getPublicKey method, also added!
I've tested this with a local snapshot. and has worked in production as well.

I'd be happy to address any changes!!

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@maddymanu maddymanu changed the title Adding Secrets + Public Key to Repository [WIP] Adding Secrets + Public Key to Repository Apr 27, 2022
@maddymanu maddymanu marked this pull request as ready for review April 27, 2022 18:58
@maddymanu maddymanu changed the title [WIP] Adding Secrets + Public Key to Repository Adding Secrets + Public Key to Repository Apr 27, 2022
Copy link
Contributor Author

@bitwiseman any chance we could get this in?
I'd be happy to address any feedback or comments!!

Copy link

Sorry for slow turn around time. Assuming all tests pass, I'll merge and publish later tonight.

Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1446 (1fa164c) into main (38918c4) will increase coverage by 0.04%.
The diff coverage is 94.11%.

@@             Coverage Diff              @@
##               main    #1446      +/-   ##
+ Coverage     78.76%   78.80%   +0.04%     
- Complexity     2107     2113       +6     
  Files           201      202       +1     
  Lines          6410     6427      +17     
  Branches        361      361              
+ Hits           5049     5065      +16     
- Misses         1151     1152       +1     
  Partials        210      210              
Impacted Files Coverage Δ 83.33% <83.33%> (ø)
src/main/java/org/kohsuke/github/ 68.93% <100.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38918c4...1fa164c. Read the comment docs.

@bitwiseman bitwiseman merged commit aa7f342 into hub4j:main Jun 21, 2022
Copy link
Contributor Author

No worries at all @bitwiseman !!! TY so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants