Add type and site_admin fields to GHPerson #644
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Helps with #126. This adds the
typeandsite_adminfield from the API toGHPerson. It does not completely solve the issue, but at least you can usegetType()to see whether the owner is actually a User or an Organization.NOTE: I'm not sure I need the calls to
populate(); it worked fine without them in my unit tests. How can I be sure?