Make getTeambySlug faster #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
To fix test I would need access to https://github.com/github-api-test-org |
bitwiseman
requested changes
Mar 16, 2020
Member
bitwiseman
left a comment
bitwiseman
left a comment
There was a problem hiding this comment.
Need updates to tests and auto-formatting. Thanks!
Member
|
Invited to test org. 😄 |
Co-Authored-By: Liam Newman <bitwiseman@gmail.com>
Contributor
Author
|
@bitwiseman Thanks for org invite.. now will be easier with tests.. |
bitwiseman
reviewed
Mar 17, 2020
| GHOrganization organization = gitHub.getOrganization(GITHUB_API_TEST_ORG); | ||
| GHTeam teamByName = organization.getTeams().get("Core Developers"); | ||
|
|
||
| GHTeam teamById = gitHub.getTeam(teamByName.getId()); |
Member
There was a problem hiding this comment.
Sorry, just because it is deprecated doesn't mean we can remove the test for it. We must ensure it continues to work until it is removed.
bitwiseman
requested changes
Mar 17, 2020
Member
bitwiseman
left a comment
bitwiseman
left a comment
There was a problem hiding this comment.
One more test change and then i can merge. Thanks!
bitwiseman
approved these changes
Mar 17, 2020
Member
bitwiseman
left a comment
bitwiseman
left a comment
There was a problem hiding this comment.
Thanks for fast turnaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change method how
getTeambySlugworks... (direct api call instead of getting list and iterating)Wit bigger organisations getting all teams can take a lot of times..
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn -D enable-ci clean install sitelocally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.