Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "workflow_dispatch" to GHEvent #874

Merged
merged 1 commit into from Jul 2, 2020
Merged

Conversation

bitwiseman
Copy link
Member

@bitwiseman bitwiseman commented Jul 1, 2020

Description

This event is undocumented at this time, but this change will stop the deserialization errors.

Fixes #854

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than master. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn clean compile locally. This may reformat your code, commit those changes.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

This event is undocumented at this time, but this change will stop the deserialization errors.

Fixes #854
@bitwiseman bitwiseman merged commit 666bd77 into master Jul 2, 2020
@didier-durand
Copy link

Can you say in which official release of the library this fix will be included? Thanks!
Didier

@bitwiseman bitwiseman deleted the bitwiseman-patch-1 branch April 19, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants