Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StdoutExporter: json output format #10

Closed
bpetit opened this issue Nov 19, 2020 · 8 comments
Closed

StdoutExporter: json output format #10

bpetit opened this issue Nov 19, 2020 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
General

Comments

@bpetit
Copy link
Contributor

bpetit commented Nov 19, 2020

Have a clean json output with an attached option flag in stdout exporter.
@bpetit bpetit created this issue from a note in General (Triage) Nov 19, 2020
@bpetit bpetit self-assigned this Nov 19, 2020
@bpetit bpetit added the enhancement New feature or request label Nov 19, 2020
@bpetit bpetit removed their assignment Nov 26, 2020
@bpetit bpetit changed the title stdout exporter: json output format StdoutExporter: json output format Nov 26, 2020
@luiscruz
Copy link

luiscruz commented Dec 9, 2020

Hi @bpetit do you think this could be a good contribution for a newcomer? I'd be happy to help.

@bpetit bpetit added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 9, 2020
@bpetit
Copy link
Contributor Author

bpetit commented Dec 9, 2020

Hi ! Thanks for your message ! It is a good first issue imho !
Don't hesitate to propose a PR :)

@luiscruz
Copy link

luiscruz commented Dec 9, 2020

Excellent! I'll give it a try next week (hope it fits your plan/time constraints).

@bpetit
Copy link
Contributor Author

bpetit commented Dec 9, 2020

No particular time constraint on that particular topic. Next week is perfect ! Thanks !

@luiscruz
Copy link

Hi there, just a quick update.
I haven't done this yet because I'm taking some time to learn Rust before doing any PR. (doing all the Rust by Example exercises)
Hope this is not an urgent issue. I'd like to keep it in my agenda, if you don't mind.

@bpetit
Copy link
Contributor Author

bpetit commented Dec 22, 2020

No problem, no rush on this task. You can keep it. Thanks for your motivation ! Happy rusting !

@luiscruz
Copy link

Thanks! :)

@bpetit bpetit moved this from Triage to To do in General Feb 3, 2021
@bpetit bpetit moved this from To do to In progress in General Feb 3, 2021
@bpetit bpetit moved this from In progress to To do in General Feb 8, 2021
@bpetit
Copy link
Contributor Author

bpetit commented Feb 8, 2021

It seems like this feature will be redundant with the new JsonExporter:

@luiscruz would you like to jump on this PR and help review it instead ?

@bpetit bpetit closed this as completed Feb 8, 2021
General automation moved this from To do to Done Feb 8, 2021
@bpetit bpetit moved this from Done to Previous releases in General Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
General
Previous releases
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bpetit @luiscruz