Skip to content

/huboard-web

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps rails from 4.2.0 -> 4.2.4 #217

Merged
merged 2 commits into from Mar 7, 2016
Merged

Bumps rails from 4.2.0 -> 4.2.4 #217

merged 2 commits into from Mar 7, 2016

Conversation

@dahlbyk
Copy link
Member

dahlbyk commented Mar 3, 2016

Pulling this out of #211 so we can 🚢 it separately.
@discorick @dahlbyk
Bumps rails from 4.2.0 -> 4.2.4, Adds a preview interceptor for maile…
aa69e98 
…r previews (makes inline images work)
@dahlbyk dahlbyk deployed to huboard-rails-pr-217 Mar 3, 2016 Active
Gemfile.lock
nokogiri (1.6.6.2)
mini_portile (~> 0.6.0)
nokogiri (1.6.7.2)
mini_portile2 (~> 2.0.0.rc2)

This comment has been minimized.

Sign in to view
Copy link
@dahlbyk

dahlbyk Mar 3, 2016

Author Member

Any idea why this is 2.0.0.rc2 when version is 2.0.0 above?
@discorick
Adjusts payload as Rails 4.2.4 does not assume HWID between jobs queu…
c02ed1a 
…ed by jobs
@discorick discorick deployed to huboard-rails-pr-217 Mar 7, 2016 Active
@discorick

This comment has been minimized.

Sign in to view
Copy link
Member

discorick commented Mar 7, 2016

Ok @dahlbyk I am pretty confident wit this one now - I ran into a problem with arguments not serializing/deserializing between ActiveJobs and it took me way to long to figure out what was wrong.

Essentially plain Hash's are now being transported as such, before this upgrade they were being automatically coalesced into HashWithIndifferentAccess

See c02ed1a
@seanlinsley

This comment has been minimized.

Sign in to view
Copy link

seanlinsley commented Mar 7, 2016

Y'all should upgrade to 4.2.5.2 soon. It includes a number of security fixes.
@dahlbyk

This comment has been minimized.

Sign in to view
Copy link
Member Author

dahlbyk commented Mar 7, 2016

See c02ed1a

👍

Y'all should upgrade to 4.2.5.2 soon. It includes a number of security fixes.

@discorick thoughts on doing this now while we're already bumping versions?
@discorick

This comment has been minimized.

Sign in to view
Copy link
Member

discorick commented Mar 7, 2016

@seanlinsley @dahlbyk I would like to get this guy merged in first to unblock some PR's in flight. But point taken, +1 for security fixes, we should look into 4.2.5.2 as soon as we can
discorick added a commit that referenced this pull request Mar 7, 2016
@discorick
Merge pull request #217 from huboard/rails-4.2.4
3934e45 
Bumps rails from 4.2.0 -> 4.2.4
@discorick discorick merged commit 3934e45 into master Mar 7, 2016
@discorick discorick deleted the rails-4.2.4 branch Mar 7, 2016
@dahlbyk dahlbyk mentioned this pull request Mar 7, 2016
Closed
@dahlbyk

This comment has been minimized.

Sign in to view
Copy link
Member Author

dahlbyk commented Mar 7, 2016

But point taken, +1 for security fixes, we should look into 4.2.5.2 as soon as we can

Issue created. Thanks for the tip @seanlinsley!
@dahlbyk dahlbyk mentioned this pull request Mar 8, 2016
Closed
@discorick discorick mentioned this pull request Mar 8, 2016
Merged
@dahlbyk dahlbyk mentioned this pull request Mar 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dahlbyk @discorick @seanlinsley
You can’t perform that action at this time.