Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

@robot undefined when streaming connection closes #197

Closed
tombell opened this Issue Nov 28, 2011 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

tombell commented Nov 28, 2011

The @robot is undefined when the streaming connection ends and a message is logged. I'll look into this tonight.

pbyrne commented Nov 28, 2011

I can confirm that we're getting the same behavior after updating from Hubot 1.1.11 to 2.0.4. Below is the Heroku log from the crash.

2011-11-28T17:55:03+00:00 app[app.1]: /app/node_modules/hubot/src/adapters/campfire.coffee:213
2011-11-28T17:55:03+00:00 app[app.1]:               this.robot.logger.error("Streaming connection closed. :(");
2011-11-28T17:55:03+00:00 app[app.1]:                         ^
2011-11-28T17:55:03+00:00 app[app.1]: TypeError: Cannot read property 'logger' of undefined
2011-11-28T17:55:03+00:00 app[app.1]:     at IncomingMessage.<anonymous> (/app/node_modules/hubot/src/adapters/campfire.coffee:10:95)
2011-11-28T17:55:03+00:00 app[app.1]:     at Object.<anonymous> (/app/node_modules/hubot/src/adapters/campfire.coffee:213:25)
2011-11-28T17:55:03+00:00 app[app.1]:     at IncomingMessage.emit (events.js:81:20)
2011-11-28T17:55:03+00:00 app[app.1]:     at HTTPParser.onMessageComplete (http.js:133:23)
2011-11-28T17:55:03+00:00 app[app.1]:     at CleartextStream.ondata (http.js:1213:22)
2011-11-28T17:55:03+00:00 app[app.1]:     at CleartextStream._push (tls.js:291:27)
2011-11-28T17:55:03+00:00 app[app.1]:     at SecurePair._cycle (tls.js:565:20)
2011-11-28T17:55:03+00:00 app[app.1]:     at EncryptedStream.write (tls.js:97:13)
2011-11-28T17:55:03+00:00 app[app.1]:     at Socket.ondata (stream.js:40:26)
2011-11-28T17:55:03+00:00 app[app.1]:     at Socket.emit (events.js:64:17)
2011-11-28T17:55:03+00:00 heroku[app.1]: Process exited
2011-11-28T17:55:04+00:00 heroku[app.1]: State changed from up to crashed

@tombell tombell closed this in e1f5ade Nov 29, 2011

glucero pushed a commit to absperf/hubot that referenced this issue Aug 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment