Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Clarify use of hubot-scripts.json #21

Merged
merged 5 commits into from Oct 25, 2011

Conversation

Projects
None yet
5 participants
Contributor

skalnik commented Oct 25, 2011

Loading scripts via hubot-scripts.json isn't very obvious. I've added a hubot-scripts.json file which contains an empty array to the templates which makes the layout more obvious, and updated the README to clarify that the extension is required.

minter commented Oct 25, 2011

What's the format of the hubot-scripts.json? I tried:

[ 'speak.coffee', 'adult.coffee' ]

And got a syntax error.

Contributor

skalnik commented Oct 25, 2011

JSON strings are double quoted, so you'll need to do:

[ "speak.coffee", "adult.coffee" ]
Contributor

titanous commented Oct 25, 2011

Why not add a few to the template as an example?

Contributor

skalnik commented Oct 25, 2011

JSON doesn't allow for comments as far as I know, but I suppose adding a few scripts would be a good idea, though it may be assuming too much.

Contributor

searls commented Oct 25, 2011

+1 for adding some examples; couldn't hurt

@atmos atmos added a commit that referenced this pull request Oct 25, 2011

@atmos atmos Merge pull request #21 from skalnik/master
Clarify use of hubot-scripts.json
e016fa7

@atmos atmos merged commit e016fa7 into hubotio:master Oct 25, 2011

@glucero glucero pushed a commit to absperf/hubot that referenced this pull request Aug 20, 2012

@atmos atmos Merge pull request #21 from skalnik/master
Clarify use of hubot-scripts.json
83ff8c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment