From 87c97b2fe4b3bccdd184aced6e9fe7c32281230d Mon Sep 17 00:00:00 2001 From: Sam Wilson Date: Fri, 25 Sep 2015 10:33:43 -0400 Subject: [PATCH 1/3] Remove manual style checking and linting in favor of style ci service --- .travis.yml | 2 -- composer.json | 2 -- 2 files changed, 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 219a7af..c65064b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -12,8 +12,6 @@ install: composer install --prefer-source --no-interaction script: - mkdir -p build/logs - vendor/bin/phpunit - - vendor/bin/phpcs --standard=PSR2 src/ - - vendor/bin/parallel-lint src/ after_script: - php vendor/bin/coveralls diff --git a/composer.json b/composer.json index 6d958f8..2e02a1e 100644 --- a/composer.json +++ b/composer.json @@ -9,8 +9,6 @@ }, "require-dev": { "phpunit/phpunit": "4.*", - "squizlabs/php_codesniffer": "2.*", - "jakub-onderka/php-parallel-lint": "0.9.*", "satooshi/php-coveralls": "dev-master" }, "autoload": { From c85f9dc64e527bd04306d0673e00d2f527316d7f Mon Sep 17 00:00:00 2001 From: Sam Wilson Date: Fri, 25 Sep 2015 10:38:54 -0400 Subject: [PATCH 2/3] Fix for PSR2 spec compliance --- tests/Http/CurlTest.php | 12 ++++-------- tests/ProfileTest.php | 2 +- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/tests/Http/CurlTest.php b/tests/Http/CurlTest.php index 9aa0922..d241ecf 100644 --- a/tests/Http/CurlTest.php +++ b/tests/Http/CurlTest.php @@ -59,8 +59,7 @@ private function curl() **/ public function testNewCurlCallsInitialize() { - $call = function() - { + $call = function() { $curl = new Curl; }; @@ -75,8 +74,7 @@ public function testNewCurlCallsInitialize() **/ public function testCurlResetCallsClose() { - $call = function() - { + $call = function() { $curl = new Curl; $curl->reset(); }; @@ -92,8 +90,7 @@ public function testCurlResetCallsClose() **/ public function testCurlExecutes() { - $call = function() - { + $call = function() { $curl = new Curl; $curl->execute(); }; @@ -109,8 +106,7 @@ public function testCurlExecutes() **/ public function testSetOptCallsSetOptWithParameter() { - $call = function() - { + $call = function() { $curl = new Curl; $curl->setOpt(CURLOPT_URL, 'http://hubzero.org'); }; diff --git a/tests/ProfileTest.php b/tests/ProfileTest.php index 33fad25..e0c5345 100644 --- a/tests/ProfileTest.php +++ b/tests/ProfileTest.php @@ -121,4 +121,4 @@ public function testGetName() { $this->assertEquals('Test User', $this->profile()->fullName(), 'Failed to fetch full name from profile data'); } -} \ No newline at end of file +} From 6c18cda0304714b19c89f70110ea3f8906bf3ad3 Mon Sep 17 00:00:00 2001 From: Sam Wilson Date: Fri, 25 Sep 2015 10:40:31 -0400 Subject: [PATCH 3/3] Add style ci badge to readme --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 99e3040..e8f54b3 100644 --- a/README.md +++ b/README.md @@ -3,6 +3,7 @@ PHP Library for ORCID [![Build Status](https://travis-ci.org/hubzero/orcid-php.svg?branch=master)](https://travis-ci.org/hubzero/orcid-php) [![Coverage Status](https://coveralls.io/repos/hubzero/orcid-php/badge.svg?branch=master&service=github)](https://coveralls.io/github/hubzero/orcid-php?branch=master) +[![StyleCI](https://styleci.io/repos/38449188/shield)](https://styleci.io/repos/38449188) This library was started to support the ORCID OAuth2 authentication workflow. It also supports basic profile access, but is a work in progress. More features are to come as needed by the developer or requested/contributed by other interested parties.