Permalink
Browse files

Fix render_views for anonymous controllers on 1.8.7.

Rails uses a controller's class name to determine the layout to use when
rendering views but it does so with an inherited hook. This means that
setting the name of a class *after* it inherits is too late. This is not
an issue in Ruby 1.9.2 as the name of an anonymous module is set to nil
but in 1.8.7 it is set to the empty string (which, of course, is a
truthy value). This causes Rails to throw a "can't convert nil into
String" error when attempting to render views from an anonymous
controller.

We can fix this by declaring an anonymous controller's name *on
creation* and then evaluating the body of the controller with
`class_eval`.
  • Loading branch information...
1 parent 002f1da commit f629d018b3e4216f1b2c885433af481ad361f9f4 James Hunt & Paul Mucur committed with mudge Apr 1, 2012
@@ -328,3 +328,33 @@ Feature: anonymous controller
"""
When I run `rspec spec`
Then the examples should all pass
+
+ Scenario: rendering views
+ Given a file named "spec/controllers/application_controller_spec.rb" with:
+ """
+ require "spec_helper"
+
+ describe ApplicationController do
+ render_views
+
+ controller do
+ def index
+ @name = "Bob"
+ end
+ end
+
+ describe "#index" do
+ it "greets the user" do
+ get :index
+ response.body.should =~ /Hello there, Bob/
+ end
+ end
+ end
+ """
+ And a file named "app/views/anonymous/index.html.erb" with:
+ """
+ Hello there, <%= @name %>
+ """
+ When I run `rspec spec`
+ Then the examples should all pass
+
@@ -58,10 +58,10 @@ def controller(base_class = nil, &body)
controller_class :
ApplicationController
- metadata[:example_group][:described_class] = Class.new(base_class, &body)
- metadata[:example_group][:described_class].singleton_class.class_eval do
- def name; "AnonymousController" end
+ metadata[:example_group][:described_class] = Class.new(base_class) do
+ def self.name; "AnonymousController"; end
end
+ metadata[:example_group][:described_class].class_eval(&body)
before do
@orig_routes, @routes = @routes, ActionDispatch::Routing::RouteSet.new

0 comments on commit f629d01

Please sign in to comment.