Make ingress egress ratelimit bins separate again. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment text says "downprioritize", where in fact it does reverse cs1->cs0 simple code would be ip dscp lt cs4 ip dsccp ne cs1
This reverts commit 2b81c6c.
#7 applies limit to both connection directions effectively halving intended rate Restore rate limit bidirectionality Adds 1 byte to 4 byte ct id in keys Less accurate alternative could have been doubling calculated packet rates. Signed-off-by:
|
oops, ill re-base #15 on top of this if you dont manage today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore rate limit bidirectionality fixing #7 which effectively halved intended packet rate (per bin)
Adds 1 byte to int32 ct id.
alternative could have been doubling rates in calculation, lets better keep in and out counts separate as before.
Signed-off-by: Andris PE neandris@gmail.com