Permalink
Commits on Oct 18, 2016
  1. Bump to 3.1.0

    huerlisi committed Oct 18, 2016
Commits on Dec 16, 2015
  1. Bump to 3.0.0.beta3

    huerlisi committed Dec 16, 2015
  2. Merge pull request #4 from huerlisi/fixes/ruby-1-9

    huerlisi committed Dec 16, 2015
    fix(ruby): stay compatible with ruby 1.9
  3. fix(ruby): stay compatible with ruby 1.9

    huerlisi committed Dec 16, 2015
Commits on Nov 23, 2015
  1. Update CHANGELOG.

    huerlisi committed Nov 23, 2015
  2. Bump to 3.0.0.beta2

    huerlisi committed Nov 23, 2015
  3. Merge pull request #3 from huerlisi/features/find_account_by_tag

    huerlisi committed Nov 23, 2015
    feat(Account): implement Account.find_by_tag
  4. feat(Account): implement Account.find_by_tag

    huerlisi committed Nov 23, 2015
    We support looking up Accounts by tags when the acts-as-taggable-on gem
    is used. Looking up by tags might lead to multiple findings, which is
    not always what we want. When needing a single instance, as when
    assigning to a Booking, you may use the `.find_by_tag` method which
    raises an `Account::AmbiguousTag` error if multiple Accounts are
    candidates.
    
    Thanks go to luxflux for implementing this while working on API support
    for Bookyt: huerlisi/bookyt#82
  5. fix(Gemfile): pin acts-as-taggable gem to compatible version

    huerlisi committed Nov 23, 2015
    We do include the acts-as-taggable gem in our Gemfile for testing. But
    we are not yet supporting the newest version of it. Therefore we need to
    add an explicit version to the dependency specification.
  6. spec: improve account factory

    huerlisi committed Nov 23, 2015
    The account factory does not create new Account entries for the same
    code, but returns existing ones. This is good for performance purposes
    but also simplifies creating booking instances for designated accounts.
    It did only create a single instance when called without an explicit
    code. This is not the intended behaviour.
    
    This patch assigns a factored account instance a random code.
Commits on Sep 3, 2015
  1. feat(booking): allow filtering by code

    huerlisi committed Sep 3, 2015
    Looking up a booking for a receipt code is a common tasks.
    
    This patch adds Booking.by_code scope.
Commits on Jul 25, 2015
  1. test: use exception classes

    huerlisi committed Jul 25, 2015
    When we raise exceptions from our code it should have some semantics. In
    the case of looking up records we use the ActiveRecord::Error classes.
    
    This patch changes the returned exceptions for booking and template
    lookups to ActiveRecord::RecordNotFound instances.
    
    Affected methods:
    * BookingTemplate.build_booking
Commits on Jun 28, 2015
  1. Bump to 3.0.0.beta1

    huerlisi committed Jun 28, 2015
  2. test(rspec): prevent minitest runner call on Ruby < 2.2

    huerlisi committed Jun 28, 2015
    We had issues with running `rspec` on Ruby < 2.2.
    
    This patch prevents Test::Unit's AutoRunner from executing during RSpec's rake task.
  3. test(models): fix parameters to factory call in model spec

    huerlisi committed Jun 28, 2015
    We passed twice the same parameter in a factory call. The spec itself
    was proper though.
    
    This patch fixes the factory calls.
  4. chore(gems): update all gems, making ready for Ruby 2.2

    huerlisi committed Jun 28, 2015
    Rails 3.2 had an issue with Ruby 2.2. Latest Rails release 3.2.22 now
    fixed this.
    
    This patch updates all gems and makes it ready for Ruby 2.2.
Commits on May 31, 2015
  1. feat(Booking): drop Booking.by_value_date scope

    huerlisi committed May 31, 2015
    The .by_value_date and .by_value_period scopes duplicate functionality
    of the more versatile .by_date.
    
    BREAKING CHANGE:
    This patch drops the .by_value_date and .by_value_period scopes.
Commits on May 29, 2015
  1. Revert "chore(travis): drop bogus sudo setting"

    huerlisi committed May 29, 2015
    It seems that without explicit setting `sudo: false` we do not build
    on docker.
    
    This reverts commit cc3b467.
  2. fix(travis): do not build on ruby 2.2

    huerlisi committed May 29, 2015
    Ruby 2.2 is not properly supported by Rails 3.2
    
    This patch drops Ruby 2.2 from the build targets on Travis.
  3. fix(test): drop unused test-unit gem

    huerlisi committed May 29, 2015
    The test-unit gem was added to fix some issues on newer Ruby versions
    but triggers error when running `rspec`.
    
    This patch drops the `test-unit` gem.
  4. chore(travis): drop bogus sudo setting

    huerlisi committed May 29, 2015
    Travis now uses docker based containers by default.
    
    This patch drops the therefore unused `sudo: false` setting for
    Travis.
  5. fix(travis): drop now unsupported ruby 1.9

    huerlisi committed May 29, 2015
    has_accounts fails on travis due to the inclusion of incompatible
    gems. Ruby version 1.9 is not supported in the upcomming 3.0 release.
    
    This patch drops building for Ruby 1.9 on Travis.
  6. Bump to 3.0.0.beta0

    huerlisi committed May 29, 2015
  7. refactor(spec): convert specs to RSpec 3.2.1 syntax with Transpec

    huerlisi committed May 29, 2015
    This conversion is done by Transpec 3.0.8 with the following command:
        transpec -f
    
    * 31 conversions
        from: obj.should
          to: expect(obj).to
    
    * 21 conversions
        from: == expected
          to: eq(expected)
    
    * 13 conversions
        from: it { should ... }
          to: it { is_expected.to ... }
    
    * 8 conversions
        from: it { should_not ... }
          to: it { is_expected.not_to ... }
    
    * 1 conversion
        from: obj.should_not
          to: expect(obj).not_to
    
    * 1 conversion
        from: obj.stub_chain(:message1, :message2)
          to: allow(obj).to receive_message_chain(:message1, :message2)
    
    For more details: https://github.com/yujinakayama/transpec#supported-conversions
  8. refactor(test): unify Booking.by_date specs with .by_amount

    huerlisi committed May 29, 2015
    The .by_date and .by_amount scopes have a similar interface and
    should have similar scenarios tested.
    
    This patch unifies the specs for .by_amount and .by_date.
  9. feat(Booking): add Booking.by_date scope

    huerlisi committed May 29, 2015
    Querying by amount is a common use case when working with Booking
    objects.
    
    This patch introduces a .by_amount accepting single amounts or
    two parameters for minimum and/or maximum amounts
  10. feat(Booking): add Booking.by_date scope

    huerlisi committed May 29, 2015
    Querying by value date is a common use case when working with Booking
    objects.
    
    This patch introduces a .by_date scope accepting single dates or
    two parameters for start and/or end date.
    
    This scope overlapps with the .by_value_period and .by_value_date methods.
    They will be deprecated in a further release.
  11. chore(test): add pry-byebug gem

    huerlisi committed May 29, 2015