Skip to content

Update FSDP mixed precision setter to enable fsdp+qlora #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. Update FSDP mixed precision setter to enable fsdp+qlora. When using quantization storage datatype as float32, the MixedPrecision policy should use float32 but with autocasting enabled. This PR supports this.
  2. It adds override argument to force update the mixed precision policy.
  3. It adds buffer_autocast argument to support casting buffers to float32 which can be important for RoPE layer which gives incorrect results when cast to lower precision especially with longer context lengths.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pacman100 pacman100 marked this pull request as ready for review March 12, 2024 09:25
@pacman100 pacman100 merged commit 92b1ad0 into huggingface:main Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants