Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate metrics #4739

Merged
merged 27 commits into from
Jul 28, 2022
Merged

Deprecate metrics #4739

merged 27 commits into from
Jul 28, 2022

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Jul 25, 2022 •
edited
Loading

Deprecate metrics:

  • deprecate public functions: load_metric, list_metrics and inspect_metric: docstring and warning
  • test deprecation warnings are issues
  • deprecate metrics in all docs
  • remove mentions to metrics in docs and README
  • deprecate internal functions/classes

Maybe we should also stop testing metrics?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 25, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@albertvillanova albertvillanova requested a review from lhoestq July 25, 2022 10:45
lhoestq
lhoestq reviewed Jul 25, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me !

cc @stevhliu @lvwerra let us know what you think :)

docs/source/about_metrics.mdx Outdated Show resolved Hide resolved
docs/source/package_reference/loading_methods.mdx Outdated Show resolved Hide resolved
@albertvillanova albertvillanova marked this pull request as draft July 25, 2022 13:39
@albertvillanova
Copy link
Member Author

I mark this as Draft because the deprecated version number needs being updated after the latest release.

stevhliu
stevhliu approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating the deprecation message! 🤗

docs/source/how_to_metrics.mdx Outdated Show resolved Hide resolved
docs/source/index.mdx Outdated Show resolved Hide resolved
@albertvillanova albertvillanova marked this pull request as ready for review July 26, 2022 14:02
lvwerra
lvwerra approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this - looks great!

lhoestq
lhoestq approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@mariosasko
Copy link
Collaborator

Perhaps now is the time to also update the inspect_metric from evaluate with the changes introduced in #4433 (cc @lvwerra)

@lhoestq
Copy link
Member

lhoestq commented Jul 26, 2022 •
edited
Loading

What do you think of including what changes users have to do to switch to evaluate in the warning message ?
(basically replace datasets.load_metric by evaluate.load)

I think it can help users migrate to evaluate and silence the warnings

lhoestq
lhoestq reviewed Jul 26, 2022
View reviewed changes
src/datasets/load.py Outdated Show resolved Hide resolved
lhoestq
lhoestq reviewed Jul 26, 2022
View reviewed changes
setup.py Show resolved Hide resolved
@albertvillanova albertvillanova merged commit 0c1d099 into huggingface:main Jul 28, 2022
@albertvillanova albertvillanova deleted the deprecate-metrics branch July 28, 2022 11:32
@albertvillanova albertvillanova mentioned this pull request Sep 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

@stevhliu stevhliu stevhliu approved these changes

@lvwerra lvwerra lvwerra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@albertvillanova @HuggingFaceDocBuilderDev @mariosasko @lhoestq @lvwerra @stevhliu