-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert input_columns change #5006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question below.
@@ -1362,14 +1362,12 @@ def test_map_input_columns(self, in_memory): | |||
with tempfile.TemporaryDirectory() as tmp_dir: | |||
with self._create_dummy_dataset(in_memory, tmp_dir, multiple_columns=True) as dset: | |||
with dset.map(lambda col_1: {"label": col_1 % 2}, input_columns="col_1") as mapped_dset: | |||
self.assertEqual(mapped_dset[0].keys(), {"col_1", "col_2", "col_3", "label"}) | |||
self.assertEqual(mapped_dset[0].keys(), {"col_1", "label"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you remove completely the test test_map_input_columns
, introduced in #4971?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately input_columns wasn't tested before this PR, so I think it's nice to keep this test, but with the correct behavior (i.e. don't keep all the columns)
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good. Thanks.
Merging this one and I'll check if it fixes the |
Revert #4971
Fix #5005